feat: SW-2588 add xs size to Toggle and ToggleGroup - #211
Open
boramyi-ts wants to merge 4 commits into
Open
Conversation
Toggle only had sm/default/lg; add xs (h-6, r8, size-3 icon) mirroring Button's xs so the two share a scale. ToggleGroup gains the matching xs container radius, and its segmented end-corners are now size-aware (rounded to 8 at xs/sm) instead of a hardcoded rounded-l-lg/rounded-r-lg, so a small group's corners match Button/Toggle. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No issues found
About Unblocked
Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.
📖 Documentation — Learn more in our docs.
💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions.
👍 Give feedback — React to comments with 👍 or 👎 to help us improve.
⚙️ Customize — Adjust settings in your preferences.
This was referenced Sep 10, 2026
# Conflicts: # src/components/ui/toggle-group.tsx
owilliams-tetrascience
approved these changes
Sep 10, 2026
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SW-2588 — add
xssize to Toggle & ToggleGroupJira: SW-2588
First slice of the input-size harmonization (full audit + proposed scale are in the ticket). Buttons already have xs / sm / default / lg; toggles only had sm / default / lg. This adds xs so Toggle matches Button's scale, and makes ToggleGroup's radius size-aware to match.
Changes
xssize:h-6(24px),min-w-6,rounded-[min(var(--radius-md),10px)](r8),px-1.5,text-xs,size-3icon — mirroring Button'sxs. (Toggle already matched Button at sm/md/lg; this completes it.)data-[size=xs]container radius, and the segmented end-corners are now size-aware: xs/sm round to 8px instead of the previously hardcodedrounded-l-lg/rounded-r-lg(10px), so a small group's corners match a small Button/Toggle.Size ladder (ToggleGroup)
24px · r8 / 28px · r8 / 32px · r10 / 36px · r10 — the same ladder as Button. Single Toggle xs:
Tests
New
ExtraSmallstories for Toggle and ToggleGroup. The ToggleGroup one asserts the xs item is 24px tall with 8px end corners (guards the size-aware corners); the Toggle one asserts 24px. Full Toggle + ToggleGroup play suites pass (12/12) incl. the automatic axe check; typecheck + lint clean. Zephyr ids for the new stories to be generated viazephyr_sync.Follow-ups (tracked in the ticket)
Select/Switch gain xs+lg; Input/Textarea/Combobox/ComboboxChips gain a
sizeprop; Checkbox/Radio box scale; Switch/Slider track+thumb scaling. Staged as separate PRs.🤖 Generated with Claude Code