feat: SW-2591 add size prop to Switch and Slider - #214
Open
boramyi-ts wants to merge 3 commits into
Open
Conversation
Preserve the current sizes (switch sm 14x24 + default 18.4x32; slider default thumb 12 / track 4) unchanged, and add xs + lg around them: - Switch: xs 12x20 (thumb 10), lg 22x40 (thumb 20); the checked translate is thumb-relative so it stays flush at every size. - Slider: xs track 2 / thumb 10, lg track 6 / thumb 14; sm aliases default. No visual change to existing switches/sliders (default untouched). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No issues found
About Unblocked
Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.
📖 Documentation — Learn more in our docs.
💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions.
👍 Give feedback — React to comments with 👍 or 👎 to help us improve.
⚙️ Customize — Adjust settings in your preferences.
owilliams-tetrascience
approved these changes
Sep 10, 2026
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SW-2591 — add
sizeprop to Switch & SliderJira: SW-2591
The pill/track slice of the input-size harmonization (final input group). These need internal track+thumb geometry, so — per the design call — I preserved the current sizes unchanged and added
xs+lgaround them (no regression to existing switches/sliders).Switch (track h × w / thumb)
The checked translate is thumb-relative (
calc(100%-2px)), so the thumb stays flush at every size (track width = 2× thumb).Slider (track / thumb)
default(thumb 12 / track 4) unchanged;smaliases default; xs track 2 / thumb 10; lg track 6 / thumb 14.Tests
New
ExtraSmall/Largestories assert the rendered geometry (switch track 12px xs / 22px lg; slider thumb 10px xs / 14px lg) +data-size. Switch + Slider suites pass (11/11) incl. axe; typecheck + lint clean. Zephyr ids viazephyr_sync.This completes the SW-2591 input family. Full harmonization across the ticket: #211 toggles · #212 Input/Textarea/Select/Combobox · #213 Checkbox/Radio · this one Switch/Slider.
🤖 Generated with Claude Code