Fix long type on diagnostics for conditionally implemented traits - #161818
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JonathanBrouwer
approved these changes
Aug 26, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 26, 2026
Fix long type on diagnostics for conditionally implemented traits Fixes rust-lang#161439. This PR adds a short_string where it seemed to be missing according to the issue and the code surroundings. The test for it used for base the test from rust-lang#158494, but with different compiler flags. Thanks @philss @brunojabs
Member
|
Oh just remembered I wanted to say thanks for the good commits! First committing the test and then the changes that fix the problem with the test diff is so nice when reviewing |
Contributor
Author
|
@JonathanBrouwer Thanks for mentioning, I'll keep up this structure on the next PRs! |
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 26, 2026
…uwer Rollup of 4 pull requests Successful merges: - #160651 (mir: validate `Move` call arguments are locals or box derefs) - #161736 (Tidy: show todo reason when lint fails (and fix the lint's tidy allow statement which was weird and broken...)) - #161052 (Add regression test for generic inference) - #161818 (Fix long type on diagnostics for conditionally implemented traits)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 26, 2026
Rollup of 5 pull requests Successful merges: - #159502 (Enhance suggestions for unresolved links with typos path) - #161052 (Add regression test for generic inference) - #161210 (Improve missing extern crate diagnostics in Rust 2015) - #161818 (Fix long type on diagnostics for conditionally implemented traits) - #161839 (Fix doc link to pointer::addr)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 27, 2026
Rollup merge of #161818 - lsunsi:issue161439, r=JonathanBrouwer Fix long type on diagnostics for conditionally implemented traits Fixes #161439. This PR adds a short_string where it seemed to be missing according to the issue and the code surroundings. The test for it used for base the test from #158494, but with different compiler flags. Thanks @philss @brunojabs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161439.
This PR adds a short_string where it seemed to be missing according to the issue and the code surroundings.
The test for it used for base the test from #158494, but with different compiler flags.
Thanks @philss @brunojabs