Rollup of 4 pull requests - #161829
Closed
JonathanBrouwer wants to merge 11 commits into
Closed
Conversation
…call-args, r=WaffleLapkin mir: validate `Move` call arguments are locals or box derefs Fixes rust-lang#103362. This PR adds a MIR validation check for `Move` arguments passed to `Call` and `TailCall` terminators. A moved argument should be either a local or the contents of the `Box`. Other places can deinitialize memory that codegen does not track correctly. The check is only enabled with `-Zvalidate-mir`, using the same phase restriction as the existing `Copy` check. Added a regression test covering the invalid case.
…afflelapkin Tidy: show todo reason when lint fails (and fix the lint's tidy allow statement which was weird and broken...) r? @WaffleLapkin > [!NOTE] > I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.
…2009 Add regression test for generic inference Fixes rust-lang#120922. This PR tests the crash mentioned in the issue. The reduction was made with `treereduce` and it was quite drastic. This code causes the same ICE as rust-lang#120922 on 1.76, 1.77 and 1.78. 1.79 appears to fix it, and it doesn't cause ICE on stable either. I couldn't figure out a good name for the test file so I just used the issue since there were others already doing that. But I could change it if there's a better name for it. EDIT: I saw that tidy didn't like the test name, so I changed it to please it. But like I said, I couldn't think of a good name, so I'm open to suggestions.
Fix long type on diagnostics for conditionally implemented traits Fixes rust-lang#161439. This PR adds a short_string where it seemed to be missing according to the issue and the code surroundings. The test for it used for base the test from rust-lang#158494, but with different compiler flags. Thanks @philss @brunojabs
rustbot
added
A-tidy
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 26, 2026
Rollup of 4 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-1 try-job: aarch64-apple-2 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: i686-msvc-2
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 26, 2026
…uwer Rollup of 4 pull requests Successful merges: - #160651 (mir: validate `Move` call arguments are locals or box derefs) - #161736 (Tidy: show todo reason when lint fails (and fix the lint's tidy allow statement which was weird and broken...)) - #161052 (Add regression test for generic inference) - #161818 (Fix long type on diagnostics for conditionally implemented traits)
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 2738a22 failed: CI. Failed job:
|
Contributor
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Movecall arguments are locals or box derefs #160651 (mir: validateMovecall arguments are locals or box derefs)r? @ghost
Create a similar rollup