Rollup of 5 pull requests by matthiaskrgr · Pull Request #161840 · rust-lang/rust

matthiaskrgr · 2026-08-26T21:51:34Z

Successful merges:

Enhance suggestions for unresolved links with typos path #159502 (Enhance suggestions for unresolved links with typos path)
Add regression test for generic inference #161052 (Add regression test for generic inference)
Improve missing extern crate diagnostics in Rust 2015 #161210 (Improve missing extern crate diagnostics in Rust 2015)
Fix long type on diagnostics for conditionally implemented traits #161818 (Fix long type on diagnostics for conditionally implemented traits)
Fix doc link to pointer::addr #161839 (Fix doc link to pointer::addr)

@estebank

…oc-link-typo, r=mejrs Enhance suggestions for unresolved links with typos path Fixes rust-lang#159496 r? @estebank

…2009 Add regression test for generic inference Fixes rust-lang#120922. This PR tests the crash mentioned in the issue. The reduction was made with `treereduce` and it was quite drastic. This code causes the same ICE as rust-lang#120922 on 1.76, 1.77 and 1.78. 1.79 appears to fix it, and it doesn't cause ICE on stable either. I couldn't figure out a good name for the test file so I just used the issue since there were others already doing that. But I could change it if there's a better name for it. EDIT: I saw that tidy didn't like the test name, so I changed it to please it. But like I said, I couldn't think of a good name, so I'm open to suggestions.

…n-crate-edition-help, r=mejrs Improve missing extern crate diagnostics in Rust 2015 Fixes rust-lang#160026 closes rust-lang#112809

@philss

Fix long type on diagnostics for conditionally implemented traits Fixes rust-lang#161439. This PR adds a short_string where it seemed to be missing according to the issue and the code surroundings. The test for it used for base the test from rust-lang#158494, but with different compiler flags. Thanks @philss @brunojabs

Fix doc link to pointer::addr Remove some backticks that break some doc links on the `Ord`/`PartialOrd` impls for `*const T`

matthiaskrgr · 2026-08-26T21:51:52Z

@bors r+ rollup=never p=5

rust-bors · 2026-08-26T21:51:55Z

📌 Commit a78a574 has been approved by matthiaskrgr

It is now in the queue for this repository.

rust-bors · 2026-08-27T02:59:02Z

☀️ Test successful - CI
Approved by: matthiaskrgr
Duration: 3h 26s
Pushing d9dd070 to main...

github-actions · 2026-08-27T03:02:39Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing bff8e12 (parent) -> d9dd070 (this PR)

Test differences

Show 52 test diffs

Stage 1

[ui] tests/ui/editions/missing-extern-crate-suggestion-issue-160026.rs: [missing] -> pass (J0)
[ui] tests/ui/generics/inference-on-unused-generic.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/error-reporting/conditionally-implemented-trait-158423.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/error-reporting/conditionally-implemented-trait-long-type.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/error_reporting/conditionally-implemented-trait-158423.rs: pass -> [missing] (J0)
[ui (polonius)] tests/ui/editions/missing-extern-crate-suggestion-issue-160026.rs: [missing] -> pass (J1)
[ui (polonius)] tests/ui/generics/inference-on-unused-generic.rs: [missing] -> pass (J1)
[ui (polonius)] tests/ui/traits/error-reporting/conditionally-implemented-trait-158423.rs: [missing] -> pass (J1)
[ui (polonius)] tests/ui/traits/error-reporting/conditionally-implemented-trait-long-type.rs: [missing] -> pass (J1)
[ui (polonius)] tests/ui/traits/error_reporting/conditionally-implemented-trait-158423.rs: pass -> [missing] (J1)
[ui] tests/rustdoc-ui/intra-doc/typo-imported-item-issue-159496.rs: [missing] -> pass (J2)

Stage 2

[ui] tests/ui/editions/missing-extern-crate-suggestion-issue-160026.rs: [missing] -> pass (J3)
[ui] tests/ui/generics/inference-on-unused-generic.rs: [missing] -> pass (J3)
[ui] tests/ui/traits/error-reporting/conditionally-implemented-trait-158423.rs: [missing] -> pass (J3)
[ui] tests/ui/traits/error-reporting/conditionally-implemented-trait-long-type.rs: [missing] -> pass (J3)
[ui] tests/ui/traits/error_reporting/conditionally-implemented-trait-158423.rs: pass -> [missing] (J3)
[ui] tests/rustdoc-ui/intra-doc/typo-imported-item-issue-159496.rs: [missing] -> pass (J4)

Additionally, 35 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d9dd0703ba332dbdd19ae6c9bf7ab98ab7c933c7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-arm-linux-gnueabi: 59m 41s -> 1h 33m (+57.2%)
dist-i686-msvc: 1h 25m -> 2h 13m (+56.0%)
x86_64-gnu-llvm-21-1: 38m 9s -> 54m (+41.5%)
pr-check-1: 25m 35s -> 35m 44s (+39.7%)
x86_64-msvc-ext3: 1h 56m -> 1h 10m (-38.9%)
dist-i686-linux: 1h 26m -> 1h 58m (+36.7%)
x86_64-gnu-debug: 1h 29m -> 2h 1m (+35.9%)
dist-x86_64-msvc-alt: 2h 47m -> 1h 48m (-35.6%)
dist-various-2: 36m 30s -> 48m 57s (+34.1%)
x86_64-msvc-2: 2h 35m -> 1h 43m (-33.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-08-27T03:42:42Z

Finished benchmarking commit (d9dd070): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.2%]	8
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -8.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-8.3%	[-8.3%, -8.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-8.3%	[-8.3%, -8.3%]	1

Cycles

Results (primary 2.7%, secondary 21.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	21.0%	[17.7%, 24.1%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[2.7%, 2.7%]	1

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	4
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	4

Bootstrap: 474.868s -> 475.228s (0.08%)
Artifact size: 402.61 MiB -> 402.70 MiB (0.02%)

rust-bors · 2026-08-27T04:05:06Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#159502	Enhance suggestions for unresolved links with typos path	`a7efd75456d02c58d57cbcf75ade6e26705edcc6` (link)
#161052	Add regression test for generic inference	`cddf60ce337d091aa28530bd842c3c5753abd13e` (link)
#161210	Improve missing extern crate diagnostics in Rust 2015	`74ddeadae7e87ea6d49ee4b46c06c71cda6655e5` (link)
#161818	Fix long type on diagnostics for conditionally implemented …	`154f6b2ad9e8866ada8dfcf73c369b9ca2c1ba24` (link)
#161839	Fix doc link to pointer::addr	`e6a3e7359ecc9e1c4defc94f9fd65919b4034e03` (link)

parent commit: bff8e12ff5

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

lsunsi and others added 14 commits August 13, 2026 11:01

Add regression test for generic inference

92aeaf6

rename test file to avoid issue number

ef19c39

Add regression test for missing extern crate diagnostics

5cbc96b

Enhance suggestions for unresolved links with typos path

fa36454

Move test to appropriate folder

9ca0ccb

Add test for long predicates

32b99c8

Fix predicate display on fulfillment error

1908058

Improve missing extern crate diagnostics in Rust 2015

0152f8a

Fix doc link to pointer::addr

db0f4bd

Rollup merge of rust-lang#159502 - chenyukang:yukang-fix-159496-rustd…

ed470c8

…oc-link-typo, r=mejrs Enhance suggestions for unresolved links with typos path Fixes rust-lang#159496 r? @estebank

Rollup merge of rust-lang#161210 - chenyukang:yukang-fix-160026-exter…

0591d9a

…n-crate-edition-help, r=mejrs Improve missing extern crate diagnostics in Rust 2015 Fixes rust-lang#160026 closes rust-lang#112809

Rollup merge of rust-lang#161839 - maxdexh:doctor-link, r=clarfonthey

a78a574

Fix doc link to pointer::addr Remove some backticks that break some doc links on the `Ord`/`PartialOrd` impls for `*const T`

rust-bors Bot added the rollup A PR which is a rollup label Aug 26, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 27, 2026

rust-bors Bot merged commit d9dd070 into rust-lang:main Aug 27, 2026
14 checks passed

rustbot added this to the 1.100.0 milestone Aug 27, 2026

rust-bors Bot mentioned this pull request Aug 27, 2026

Clarify that pointers are not always compared by their addresses #157682

Open

Navigation Menu

Uh oh!

Uh oh!

Rollup of 5 pull requests - #161840

Rollup of 5 pull requests#161840
rust-bors[bot] merged 14 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-uzBGbKq

matthiaskrgr commented Aug 26, 2026

Uh oh!

matthiaskrgr commented Aug 26, 2026

Uh oh!

rust-bors Bot commented Aug 26, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 27, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 27, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Aug 27, 2026

Uh oh!

rust-bors Bot commented Aug 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

matthiaskrgr commented Aug 26, 2026

Uh oh!

matthiaskrgr commented Aug 26, 2026

Uh oh!

rust-bors Bot commented Aug 26, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 27, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 27, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Aug 27, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rust-bors Bot commented Aug 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants