Conversation
|
Blocked on a pre-existing test failure that this PR cannot cause. Failing job: The
Deterministic, not flaky: reran once, identical failure. The test landed in d369b0c. This PR changes only two Not fixing it here, because a one-line test-data change in another feature's file is scope creep for a download-link PR. Happy to fold it in if a maintainer prefers that over a separate fix on main. |
|
Folded the one-line test fix in, at the maintainer's request.
Verified locally: that suite now passes 7, skips the 2 One thing a reviewer should decide separately. Both variants put literal |
| heading: 'Looks like we timed out', | ||
| description: | ||
| 'To connect your mobile device and sync your Firefox data, visit firefox.com/pair on your computer.', | ||
| 'To connect your mobile device and sync your Firefox data, visit <b>firefox.com/pair</b> on your computer.', |
There was a problem hiding this comment.
@dschom This is the fix for the test failure on main
Because
This pull request
ConnectAnotherDevicePromoathttps://mzl.la/setting-appdownload.hrefassertions in the component test.Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-14114
Checklist
Other information
constants.tsstill holdsDOWNLOAD_LINK_TEMPLATE_ANDROID,DOWNLOAD_LINK_TEMPLATE_IOS, andDOWNLOAD_LINK_PAIRING_APPwith Adjust URLs. Nothing infxa-settingsreads them. I left them alone. They look worth a separate cleanup.