Conversation
Contributor
Author
|
Blocked on merge order. 15 checks pass. The one failure is Fix is already in #21016. Merge that first, then rerun here. Not duplicating the one-line fix, since identical changes in two open PRs conflict on the second merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
androidUrlandiosUrldefaults inpackages/fxa-auth-server/config/index.tstohttps://mzl.la/email-appdownload.appBadgespartial, so four templates pick up the new link with no template edits:postVerify,passwordResetAccountRecovery,cadReminderFirst,cadReminderSecond.downloadSubscriptionalone. It falls back toappStoreLinkandplayStoreLinkfrom per-product subscription metadata, which are store links for a subscribed app rather than the generic Firefox badges.Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-14115
Checklist
Put an
xin the boxes that applyHow to review (Optional)
packages/fxa-auth-server/config/index.ts, thesmtp.androidUrlandsmtp.iosUrldefaults.env:entry. Please confirm stage and prod config does not pin these values, or the change will not take effect there.Screenshots (Optional)
Not applicable, no user interface change.
Other information (Optional)
campaign=fxa-conf-emailplusadgroup=androidoradgroup=ios, so clicks split by platform and by campaign. One Bitly link for both badges reports a single total with no split. The reporter chose the single link.fxa-admin-serverkeeps its ownandroidUrlandiosUrldefaults on the old Adjust URLs. Its templates do not renderappBadges, so nothing there is user-visible. Left out of scope.