Skip to content

fix(settings): point app download buttons at Bitly link #21016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vbudhram wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

fix(settings): point app download buttons at Bitly link #21016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/fxa-settings/src/components/Settings/ConnectAnotherDevicePromo/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ describe('Connect another device Promo', () => {
await screen.findByText('Find Firefox in the Google Play and App Store.');
expect(screen.getByTestId('play-store-link')).toHaveAttribute(
'href',
'https://app.adjust.com/2uo1qc?redirect=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dorg.mozilla.firefox'
'https://mzl.la/setting-appdownload'
);
expect(screen.getByTestId('app-store-link')).toHaveAttribute(
'href',
'https://app.adjust.com/2uo1qc?redirect=https%3A%2F%2Fitunes.apple.com%2Fus%2Fapp%2Ffirefox-private-safe-browser%2Fid989804926'
'https://mzl.la/setting-appdownload'
);
});
});
Expand Down
7 changes: 5 additions & 2 deletions packages/fxa-settings/src/components/Settings/ConnectAnotherDevicePromo/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ import { SettingsContext } from '../../../models/contexts/SettingsContext';
import GleanMetrics from '../../../lib/glean';
import { FtlMsg } from 'fxa-react/lib/utils';

// Bitly smart link. It detects the platform and redirects to the correct store.
const APP_DOWNLOAD_LINK = 'https://mzl.la/setting-appdownload';

export function ConnectAnotherDevicePromo() {
const { navigatorLanguages } = useContext(SettingsContext);
const GooglePlayBadge = getStoreImageByLanguages(
Expand Down Expand Up @@ -39,15 +42,15 @@ export function ConnectAnotherDevicePromo() {
<LinkExternal
className="self-center rounded focus-visible-default outline-offset-2"
data-testid="play-store-link"
href="https://app.adjust.com/2uo1qc?redirect=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dorg.mozilla.firefox"
href={APP_DOWNLOAD_LINK}
onClick={() => GleanMetrics.accountPref.googlePlaySubmit()}
>
{GooglePlayBadge}
</LinkExternal>
<LinkExternal
className="self-center m-2 rounded focus-visible-default outline-offset-2"
data-testid="app-store-link"
href="https://app.adjust.com/2uo1qc?redirect=https%3A%2F%2Fitunes.apple.com%2Fus%2Fapp%2Ffirefox-private-safe-browser%2Fid989804926"
href={APP_DOWNLOAD_LINK}
onClick={() => GleanMetrics.accountPref.appleSubmit()}
>
{AppStoreBadge}
Expand Down
Loading