Skip to content

fix(tri): restore the verify-lean phase master lost (Closes #2268) - #2273

Merged
gHashTag merged 3 commits into
masterfrom
fix/smoke-gate-verify-lean-v2
Aug 20, 2026
Merged

fix(tri): restore the verify-lean phase master lost (Closes #2268)#2273
gHashTag merged 3 commits into
masterfrom
fix/smoke-gate-verify-lean-v2

Conversation

@gHashTag

Copy link
Copy Markdown
Owner

Closes #2268. Part of #2263, which stays open for the sweep block.

Rebuilt from #2264 with the issue reference inside the commit message, which L1 TRACEABILITY requires per commit — the previous attempt carried it only in the pull request title.

smoke_gate decides from six flags; three have zero assignments in master, so the conjunction can only be true when the caller asks for none of those phases — and the regression test asks for them. This restores the verify-lean phase verbatim from 494e659; it runs and reports OK.

It deliberately does not restore the 73-line sweep-validation block: that region carries a later deliberate edit (master hardcodes the "ss" corner where 439 passed process_corner), so splicing history over it would silently revert somebody's change.

🤖 Generated with Claude Code

… still missing

smoke_gate accepted run_verify_lean and declared verify_lean_ok, but the
phase that sets it was dropped by a batch merge — so the gate could never
pass when a caller asked for that phase, which is exactly what its own
regression test asks for. Restored verbatim from 494e659; it runs and
reports OK.

The suite is still red for one further reason, now precisely located
rather than hidden behind 'did not pass all phases': dry_run_sweep_ok has
no assignment either, and its 73-line validation block is lost the same
way. That region also carries a deliberate later edit, so restoring it is
not a blind splice — written up in #2263 for a decision rather than
guessed at here.

Closes #2268
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-20 00:09:35 UTC

Summary

Status Count
Total Open PRs 24
PRs with Failing Checks 9
PRs with All Checks Green 15
READY 7
FAILING 9
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=375b2f88cc2f != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag

Copy link
Copy Markdown
Owner Author

emit-bitexact is red here and tri pr ready correctly refuses to classify it: the workflow has a paths: filter and no push: trigger, so it had zero runs on master and zero on the last five merged pull requests — no baseline existed to compare against.

Measured rather than assumed: dispatched the workflow on master (run 32319733329). Master fails it too, and more broadly — every spec failing here also fails on master. The failure is pre-existing repository drift, not this change. Merging on that evidence; the drift is filed separately.

@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-20 01:14:04 UTC

Summary

Status Count
Total Open PRs 21
PRs with Failing Checks 7
PRs with All Checks Green 14
READY 7
FAILING 7
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=cbbfac87dff3 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag enabled auto-merge (squash) August 20, 2026 01:45
@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-20 01:46:10 UTC

Summary

Status Count
Total Open PRs 21
PRs with Failing Checks 5
PRs with All Checks Green 16
READY 7
FAILING 5
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=cbbfac87dff3 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@gHashTag
gHashTag merged commit c3eeefc into master Aug 20, 2026
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

smoke_gate: the verify-lean phase is declared but never executed

1 participant