fix(tri): a check that never ran is not a check that never failed (Closes #2276) - #2277
Merged
Conversation
…oses #2276) tri pr ready classified failures against a baseline of FAILURES elsewhere. A check missing from that baseline was printed as 'NOT failing on recent master commits' — a sentence that reads identically whether the check ran there and passed, or never ran there at all. emit-bitexact-gate.yml is the second kind: pull_request with a paths: filter and no push: trigger. Zero master runs, ever; zero of the last five merged pull requests touched the filtered paths. The verdict was assembled from zero observations in both windows and printed as evidence — the same shape as every other instrument in this project that reported what it could not see as a clean reading. Records what was OBSERVED, not only what was red, and gives the third state its own verdict: NO BASELINE / CANNOT TELL. It still blocks the merge, but names the cause as the repository's CI rather than the change under review.
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2276.
tri pr readybuilt its baseline from failures elsewhere. A check absent from that baseline was printed asNOT failing on recent master commits or in the last 5 merged PRs— which reads the same whether the check ran there and passed, or never ran there at all.emit-bitexact-gate.ymlis the second kind:pull_requestwith apaths:filter and nopush:trigger. 0 master runs ever; 0 of the last 5 merged pull requests ran it. The verdict came out of zero observations in both windows and was printed as evidence.Now the command records what was observed, not only what was red, and the third state gets its own verdict:
It still refuses to merge — but it now says the failure is a finding about the repository's CI, not about the change. A regression test asserts the two states classify differently.
🤖 Generated with Claude Code