fix(tri): restore the verify-lean phase master lost (Closes #2268) - #2264
Closed
gHashTag wants to merge 1 commit into
Closed
fix(tri): restore the verify-lean phase master lost (Closes #2268)#2264gHashTag wants to merge 1 commit into
gHashTag wants to merge 1 commit into
Conversation
… still missing smoke_gate accepted run_verify_lean and declared verify_lean_ok, but the phase that sets it was dropped by a batch merge — so the gate could never pass when a caller asked for that phase, which is exactly what its own regression test asks for. Restored verbatim from 494e659; it runs and reports OK. The suite is still red for one further reason, now precisely located rather than hidden behind 'did not pass all phases': dry_run_sweep_ok has no assignment either, and its 73-line validation block is lost the same way. That region also carries a deliberate later edit, so restoring it is not a blind splice — written up in #2263 for a decision rather than guessed at here.
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This was referenced Aug 19, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2268. Part of #2263, which stays open for the sweep block.
smoke_gatebuilds its verdict from six flags; three have zero assignments in master(
dry_run_sweep_ok,verify_lean_ok,validate_lean_standalone_ok), so the conjunction can onlybe true when the caller asks for none of those phases — and the regression test asks for them. The
blocks that set them exist in 494e659 and were dropped by a later batch merge, the same shape as
the seven definitions in #2228.
This restores the verify-lean phase verbatim; it runs and reports OK.
It deliberately does not restore the 73-line sweep-validation block: that region also carries a
later deliberate edit (master hardcodes the
"ss"corner where 439 passedprocess_cornerthrough), so splicing history over it would silently revert somebody's change. The suite therefore
stays red for one remaining, now precisely named reason instead of an opaque "did not pass all
phases".