Skip to content

fix(tri): restore the verify-lean phase master lost (Closes #2268) - #2264

Closed
gHashTag wants to merge 1 commit into
masterfrom
fix/smoke-gate-verify-lean
Closed

fix(tri): restore the verify-lean phase master lost (Closes #2268)#2264
gHashTag wants to merge 1 commit into
masterfrom
fix/smoke-gate-verify-lean

Conversation

@gHashTag

@gHashTag gHashTag commented Aug 19, 2026

Copy link
Copy Markdown
Owner

Closes #2268. Part of #2263, which stays open for the sweep block.

smoke_gate builds its verdict from six flags; three have zero assignments in master
(dry_run_sweep_ok, verify_lean_ok, validate_lean_standalone_ok), so the conjunction can only
be true when the caller asks for none of those phases — and the regression test asks for them. The
blocks that set them exist in 494e659 and were dropped by a later batch merge, the same shape as
the seven definitions in #2228.

This restores the verify-lean phase verbatim; it runs and reports OK.

It deliberately does not restore the 73-line sweep-validation block: that region also carries a
later deliberate edit (master hardcodes the "ss" corner where 439 passed process_corner
through), so splicing history over it would silently revert somebody's change. The suite therefore
stays red for one remaining, now precisely named reason instead of an opaque "did not pass all
phases".

… still missing

smoke_gate accepted run_verify_lean and declared verify_lean_ok, but the
phase that sets it was dropped by a batch merge — so the gate could never
pass when a caller asked for that phase, which is exactly what its own
regression test asks for. Restored verbatim from 494e659; it runs and
reports OK.

The suite is still red for one further reason, now precisely located
rather than hidden behind 'did not pass all phases': dry_run_sweep_ok has
no assignment either, and its 73-line validation block is lost the same
way. That region also carries a deliberate later edit, so restoring it is
not a blind splice — written up in #2263 for a decision rather than
guessed at here.
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-19 23:13:51 UTC

Summary

Status Count
Total Open PRs 23
PRs with Failing Checks 9
PRs with All Checks Green 14
READY 7
FAILING 9
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=375b2f88cc2f != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag gHashTag changed the title fix(tri): restore the verify-lean phase master lost, and name what is still missing fix(tri): restore the verify-lean phase master lost (Closes #2268) Aug 19, 2026
@gHashTag

Copy link
Copy Markdown
Owner Author

Superseded by #2273 — identical content, with Closes #2268 inside the commit message so L1 TRACEABILITY passes.

@gHashTag gHashTag closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

smoke_gate: the verify-lean phase is declared but never executed

1 participant