Skip to content

chore: declare bench frappe/erpnext dependencies - #16

Merged
Guru107 merged 2 commits into
developfrom
chore/bench-frappe-dependencies
Jul 29, 2026
Merged

chore: declare bench frappe/erpnext dependencies#16
Guru107 merged 2 commits into
developfrom
chore/bench-frappe-dependencies

Conversation

@Guru107

@Guru107 Guru107 commented Jul 29, 2026

Copy link
Copy Markdown
Owner

pyproject.toml had no [tool.bench.frappe-dependencies] section at all, so bench get-app / bench install-app ran no compatibility check — installing against an unsupported major would surface as a runtime failure rather than an install-time one. New modules need this declared.

[tool.bench.frappe-dependencies]
frappe = ">=15.0.0,<17.0.0"
erpnext = ">=15.0.0,<17.0.0"

erpnext is declared alongside frappe because the app hard-requires it for the Project and Item doctypes, and bench checks each entry independently — declaring only frappe would have left the ERPNext major unconstrained.

The range covers v15 and v16, matching the benches actually in use: frappe/erpnext 15.110.0 and 16.21.1.

The commented-out frappe~=15.0.0 in [project].dependencies is left as is — that is a pip dependency deliberately delegated to bench, and a separate mechanism from this section.

CLAUDE.md corrected

It claimed v15 in three places — Technology Stack (Framework, ERP) and Key Dependencies — which understated the supported range. All three now state >=15.0.0,<17.0.0, with a note that the ranges live in pyproject.toml and the two should be kept in sync.

Verification

  • TOML parses; section resolves to {'frappe': '>=15.0.0,<17.0.0', 'erpnext': '>=15.0.0,<17.0.0'}
  • `pre-commit run --all-files` → exit 0, including the `check toml` hook
  • No Python touched

🤖 Generated with Claude Code

New modules need the app to declare which Frappe majors it supports.
pyproject.toml had no [tool.bench.frappe-dependencies] section, so
bench performed no compatibility check at install time and a mismatch
would only surface at runtime.

Range covers v15 and v16, matching how the app is developed and tested.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
erpnext belongs alongside frappe in [tool.bench.frappe-dependencies] —
the app hard-requires it for the Project and Item doctypes, and bench
checks each entry independently, so declaring only frappe left the
ERPNext major unconstrained.

CLAUDE.md claimed v15 in three places (Technology Stack ×2, Key
Dependencies), which understated the supported range now that both
majors are declared. Verified against the benches in use: frappe/erpnext
15.110.0 and 16.21.1.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@Guru107 Guru107 changed the title chore: declare bench frappe-dependencies chore: declare bench frappe/erpnext dependencies Jul 29, 2026
@Guru107
Guru107 merged commit f4d9c98 into develop Jul 29, 2026
3 checks passed
@Guru107
Guru107 deleted the chore/bench-frappe-dependencies branch July 29, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant