Skip to content

chore: declare bench frappe-dependencies and carry v1.2.1 bump to develop - #15

Closed
Guru107 wants to merge 2 commits into
developfrom
release/v1
Closed

chore: declare bench frappe-dependencies and carry v1.2.1 bump to develop#15
Guru107 wants to merge 2 commits into
developfrom
release/v1

Conversation

@Guru107

@Guru107 Guru107 commented Jul 29, 2026

Copy link
Copy Markdown
Owner

[tool.bench.frappe-dependencies]

pyproject.toml had no [tool.bench.frappe-dependencies] section at all, so bench get-app / bench install-app ran no compatibility check — installing against an unsupported Frappe major would surface as a runtime failure rather than an install-time one. New modules need this declared.

[tool.bench.frappe-dependencies]
frappe = ">=15.0.0,<17.0.0"

The range covers v15 and v16, matching how the app is actually developed and tested (both benches are in use; the v1.2.x work was verified on each).

The commented-out frappe~=15.0.0 in [project].dependencies is left as is — that is a pip dependency deliberately delegated to bench, and a separate mechanism from this section.

Also included: 8140577

This PR is cut from release/v1, which was already one commit ahead of develop, so it also carries the v1.2.1 republish — __version__ = "1.2.1" and RELEASE_v1.2.0.mdRELEASE_v1.2.1.md. That brings develop in line with the v1.2.1 release; develop currently still reads 1.2.0.

Not included

  • erpnext is not declared. The app hard-requires ERPNext for the Project and Item doctypes, so a matching erpnext = ">=15.0.0,<17.0.0" would normally sit alongside. Left out deliberately — only frappe was specified.
  • CLAUDE.md still says "Frappe Framework: ~15.0.0 (managed by bench)", which understates the range now that v16 is declared supported.

Verification

  • TOML parses; section resolves to {'frappe': '>=15.0.0,<17.0.0'}
  • pre-commit run --all-files → exit 0, including the check toml hook
  • No Python touched

🤖 Generated with Claude Code

Guru107 and others added 2 commits July 27, 2026 11:42
v1.2.0 was tagged and then withdrawn: the repo had immutable releases
enabled, so deleting the release left an immutable tag that could not be
recreated or moved (pushes rejected with GH013, "creations being
restricted"). Republish the same work under a fresh version.

Bumps __version__ to 1.2.1 — pyproject declares dynamic = ["version"],
so flit reads it — and renames the notes to RELEASE_v1.2.1.md with a
note on the withdrawal. No code changes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
New modules need the app to declare which Frappe majors it supports.
pyproject.toml had no [tool.bench.frappe-dependencies] section, so
bench performed no compatibility check at install time and a mismatch
would only surface at runtime.

Range covers v15 and v16, matching how the app is developed and tested.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@Guru107

Guru107 commented Jul 29, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #16. This PR was cut from release/v1, which was wrong on two counts: the change was committed directly to a release branch, and the PR dragged the unrelated v1.2.1 bump along with it. #16 is a dedicated chore/bench-frappe-dependencies branch off develop with just the one commit.

@Guru107 Guru107 closed this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant