chore: sync develop into release/v1 (bench dependency declarations) - #17
Merged
Conversation
Merge pull request #13 from Guru107/develop
New modules need the app to declare which Frappe majors it supports. pyproject.toml had no [tool.bench.frappe-dependencies] section, so bench performed no compatibility check at install time and a mismatch would only surface at runtime. Range covers v15 and v16, matching how the app is developed and tested. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
erpnext belongs alongside frappe in [tool.bench.frappe-dependencies] — the app hard-requires it for the Project and Item doctypes, and bench checks each entry independently, so declaring only frappe left the ERPNext major unconstrained. CLAUDE.md claimed v15 in three places (Technology Stack ×2, Key Dependencies), which understated the supported range now that both majors are declared. Verified against the benches in use: frappe/erpnext 15.110.0 and 16.21.1. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
chore: declare bench frappe/erpnext dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
release/v1up to date withdevelopahead of re-pointing the v1.2.1 tag.What this carries
c9b9f5c[tool.bench.frappe-dependencies]withfrappe = ">=15.0.0,<17.0.0"5dfbfd3erpnext = ">=15.0.0,<17.0.0"; correct the v15-only claims inCLAUDE.md(Technology Stack ×2, Key Dependencies)b559067,f4d9c98Before this,
bench get-app/bench install-appran no compatibility check at all, so an unsupported Frappe or ERPNext major would surface as a runtime failure rather than an install-time one.Direction
release/v1is currently one commit ahead ofdevelop(8140577, the v1.2.1 republish, which thev1.2.1tag points at). That commit stays where it is — this PR only moves content the other way, so the tag's current target is unaffected by the merge itself.Verification
{'frappe': '>=15.0.0,<17.0.0', 'erpnext': '>=15.0.0,<17.0.0'}pre-commit run --all-files→ exit 0, includingcheck toml🤖 Generated with Claude Code