fix: synchronously kill crashpad_handler after device tests#58
Merged
Conversation
Replace the deferred background trap with a synchronous pkill after Gradle exits, so crashpad_handler is killed immediately instead of racing with the action's cleanup step. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ing docs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkill -9 crashpad_handlerthat runs immediately after Gradle exitsdocs/contributing/pull-requests.md(placeholder content was inaccurate)Root cause
crashpad_handler(Chromium's crash reporter, shipped with WebView) keeps the emulator process alive after tests complete. Theandroid-emulator-runneraction's cleanup waits for the emulator to exit — blocking forever.Test plan
device-testsjob: after Gradle finishes, the step should exit cleanly instead of hanging🤖 Generated with Claude Code