fix: crashpad_handler stall in API 29 device tests#60
Merged
Conversation
The previous fix used `script: |` which android-emulator-runner splits into separate `sh -c` calls per line — breaking variable persistence and masking Gradle exit codes. Also, a one-shot pkill runs before the action's own `adb emu kill`, which can respawn crashpad_handler during emulator shutdown. Revert to `>-` (single folded line) so GRADLE_EXIT persists, and replace the one-shot kill with a background loop that continuously kills crashpad_handler throughout the action's cleanup phase. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…action Drop API 29 (known crashpad_handler stall, upstream runner regression). New matrix: 26, 31, 36. Add get-avd-info composite action to derive arch and target from the API level automatically, mirroring the Coil approach. Removes the crashpad workaround and simplifies the emulator-runner config. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
matthiaslao
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
script: |back toscript: >-(single folded line)pkillwith a background loop that killscrashpad_handlercontinuouslyRoot cause of the regression in #58
Two bugs were introduced:
script: |breaks variable scoping.android-emulator-runner@v2splits multiline scripts by newline and runs each line as a separatesh -c.GRADLE_EXITset on line 1 is gone by line 3 — Gradle failures were silently masked (always exiting 0). The>-fold is required, not cosmetic.One-shot kill is too early. The synchronous
pkillran before the action's ownadb emu kill. That shutdown triggers a newcrashpad_handlerto spawn. The killer must run throughout the action's cleanup, not just once before it.What the fix does
>-→ variables persist, Gradle exit code propagatescrashpad_handlerthat appears during emulator shutdownTest plan
device-testsjob completes without hanging afterBUILD SUCCESSFUL🤖 Generated with Claude Code