test: pin cached form attribution boundary - #79
Merged
Conversation
This was referenced Aug 27, 2026
Atroci
marked this pull request as ready for review
August 27, 2026 22:59
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a cache treats
/?gclid=Aand/as the same object, visitor-specific query data can leak through server-rendered form markup. A later visitor must not acquire Visitor A's campaign data from a cached form action.Related coverage: WP Super Cache #855, WP Super Cache PR #1104, ClickTrail JS PR #20, and ClickTrail PSR middleware PR #3.
Approach
Run the shipped attribution browser script with a clean current URL and stale
/?gclid=visitor-aform action. Assert the current visitor receives nogclidand ClickTrail does not treat or rewrite the form action as attribution input. Document the cache-key, request, and browser-capture boundary beside form integration guidance.Affected Surfaces
Screenshots
N/A. No UI change.
Compatibility / Migration Notes
No runtime or migration change. This PR pins existing behavior.
Tests / Checks Run
npm run smoke: passed, including the Visitor B cached-form-action scenariogit diff --check: passedDocs Updated
docs/reference/INTEGRATIONS.md: cache and visitor ownership boundaryChangelog / Readme Impact
No changelog or product README update. Public behavior is unchanged.