fix(integrations): persist Fluent Forms attribution metadata - #81
Merged
Conversation
…cation workflow"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Continue ClickTrail improvements after releasing WordPress.org 1.9.1: carry the verified Fluent Forms response_id persistence fix, focused behavioral regression, runtime-safe packaging rules, current WordPress stable metadata, and bounded consent-not-required evidence into the GitHub mainline. Preserve ClickTrail source version 1.10.0 and GitHub v1.10.0 as Latest; do not merge or reuse closed PR #78 as a mainline downgrade. Work from an isolated branch, leave the user's dirty main worktree and separate green PR #79 untouched, validate behavior and packaging, then open a separate reviewable PR with CI.
VIZUH
What Changed
response_idschema column and add focused regression coverage.Risk Assessment
✅ Low: VIZUH — Change is bounded and preserves Fluent Forms persistence, 1.10.0 mainline versioning, package boundaries, GitHub Latest state, and separate green PR #79.
Testing
Reproduced the base Fluent Forms failure, verified corrected persisted state on PHP 8.1, built and inspected the installable package, confirmed WordPress 7.1 and GitHub Latest v1.10.0 metadata, and validated the Windows CI workflow model; local PowerShell execution remains intentionally owned by subsequent PR CI, and no UI artifact was applicable.
/home/hugocarvalho/.no-mistakes/evidence/01M12R24ZHGKQYY0RDEXBPF14R/click-trail-handler-1.10.0.zip)Evidence: Fluent Forms before/after evidence
Evidence: Package contract evidence
Evidence: Windows workflow semantic model
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed (2) ✅
RELEASING.md:47- VIZUH — The newly canonicalnpm run make-zippath invokespowershell, while its script requires Windows-onlyrobocopy. Linux/macOS release hosts now fail before creating an archive; retain a supported POSIX fallback or provide a cross-platform packager.🔧 Fix: VIZUH VIZUH — Add cross-platform release packaging dispatcher
1 warning still open:
tools/release/make-zip.js:65- VIZUH —makePosixZip()runsrsyncbefore deleting an existing same-version ZIP. Ifrsyncis absent or fails, command exits nonzero but leaves stale archive available for later copy/upload. Delete target before first fallible build command or during failure cleanup.🔧 Fix: VIZUH VIZUH — Clean failed packaging artifacts
✅ Re-checked - no issues remain.
🔧 **Test** - 1 issue found → auto-fixed ✅
tools/release/make-zip.ps1- Windows packaging could not be executed locally because no Windows runtime or PowerShell is available. POSIX packaging is proven; require a Windows CI run if executable evidence formake-zip.ps1is mandatory before approval.git status --short --branch, base-to-target diff, changed-file list, and commit history inspectionContainerizedcomposer install --no-plugins --no-scriptsinto transient.test-vendorfor focused PHPUnit executionPHPUnit selectorFluentFormsAdapterTest::test_submission_meta_uses_fluent_forms_response_id_columnunder PHP 8.1Base-commit execution of the same persistence regression; reproduced missingresponse_idfailureContainerized PHP 8.1 submission probe showingct_ft_source,ct_lt_source, andct_ft_campaignpersisted against Fluent entryresponse_id9001npm run make-zipunzip -t dist/click-trail-handler-1.10.0.zipplus executable archive manifest/version assertionsOfficial WordPress core version API comparison against packagedTested up tometadata; confirmed WordPress 7.1GitHub latest-release API comparison confirmingv1.10.0Evidence JSON parsing and ZIP SHA-256 verification🔧 Fix: VIZUH {"summary":"VIZUH Add Windows package verification workflow"}
✅ Re-checked - no issues remain.
git diff --name-status c72bc6cd15aad187b63a303f80d45fb446e7f5c2..7d850eb173b9a79d9e848088f8cad8844cc966f5PHP 8.1 baseline harness againstc72bc6cd15aad187b63a303f80d45fb446e7f5c2php vendor/bin/phpunit --configuration phpunit.xml.dist --filter FluentFormsAdapterTest tests/unit/FluentFormsAdapterTest.phpinside isolated PHP 8.1 Podman runtimePHP 8.1 manualFluent_Forms_Adapter::on_submission()persistence checknpm run make-zipExecutable ZIP inspection usingunzip -Z1,unzip -p, JSON parsing, and SHA-256PyYAML semantic parse of.github/workflows/package.ymlOfficial WordPress Core API and GitHub Releases API checksgit status --shortplus transient-directory cleanup verification✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.