fix: report connected source ports missing PCB mappings - #3354
Draft
AnasSarkiz wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pcb_port_not_matched_errorand feed it into Core's existing pre-routing placement-error gateRoot cause
The MangoPi imports provide
thermalpadas a required physical alias, but their wrapper spreads caller props after the importedpinLabels. A board-levelpinLabelsoverride therefore erases that alias before Core receives the<chip>. The footprint exposes onlythermalpad, so Core cannot authoritatively reconstruct pin 89 or pin 9 without guessing from footprint order.Core's bug was that this final malformed state passed placement validation:
Port.doInitialPcbPortRenderproduced no PCB port, and routing was allowed to continue. This change checks the completed Circuit JSON atPcbPlacementDesignRuleChecks, reports the exact source ports, and prevents autorouting. It deliberately does not re-enable implicit named-pad numbering, which would regress mechanical footprint hints.The importer generator should separately merge caller labels with required imported physical aliases while both mappings are still available.
Testing
bun testfocused/high-risk suite: 11 passed, 0 failedbunx tsc --noEmitbunx biome format .bun run buildbun run smoke-test:distbunx @tscircuit/dependency-checkSupersedes the Core-generated-Circuit-JSON portion of tscircuit/checks#216.