Detect connected source ports missing PCB mappings - #216
Conversation
imrishabh18
left a comment
There was a problem hiding this comment.
IIUC this is a core bug if you see this issue
seveibar
left a comment
There was a problem hiding this comment.
Visual Snapshot? This does not seem like a user bug but a core bug?
|
Moved the Core-owned producer invariant to tscircuit/core#3354 based on this review and the natural MangoPi repro. The trace confirmed that the imported This draft should not merge unchanged alongside core#3354 because both implementations would emit the same placement diagnostic. |
Summary
checkSourcePortsHavePcbPortsto placement validationpcb_port_not_matched_errorwhen a connected, PCB-backed source port lacks an owner-matched PCB portRoot cause
The existing routing checks begin from
pcb_portrecords or filter out source ports without a PCB mapping. Removing apcb_porttherefore also removed the evidence those checks needed, sorunAllPlacementChecksreturned no error.Impact
Placement validation now diagnoses missing physical port mappings before routing. Unconnected ports, source-only circuits, and components with explicit footprint-load failures remain unaffected.
Testing
bun test— 186 passed, 0 failedbun run buildgit diff --check