[codex] Add overlapping via pad short reproduction - #213
Draft
seveibar wants to merge 3 commits into
Draft
Conversation
* Detect different-net via pad clearance * Consolidate different-net via spacing checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction
spi-display-webcam-interceptorcheckDifferentNetViaSpacingand the completerunAllRoutingCheckspipeline currently return no diagnosticThis PR intentionally records current behavior only. A follow-up fix can change the expectation when different-net via copper-pad overlap is checked independently of drill-hole spacing.
Root cause captured
checkDifferentNetViaSpacingcurrently calculates clearance fromhole_diameter. That enforces the manufacturing drill-hole spacing rule, but it does not detect overlappingouter_diametercopper pads on different nets.Related autorouter reproduction: tscircuit/tscircuit-autorouter#2147
Verification
bun test(175 pass, 6 snapshots)bun run buildbunx tsc --noEmitbunx biome format tests/repros/repro-overlapping-different-net-via-pads.test.ts