Skip to content

[codex] Detect different-net via pad clearance - #214

Merged
seveibar merged 2 commits into
codex/repro-overlapping-via-shortfrom
codex/fix-different-net-via-pad-clearance
Aug 18, 2026
Merged

[codex] Detect different-net via pad clearance#214
seveibar merged 2 commits into
codex/repro-overlapping-via-shortfrom
codex/fix-different-net-via-pad-clearance

Conversation

@seveibar

@seveibar seveibar commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • extend checkDifferentNetViaSpacing to check both drill-hole and copper-pad clearance
  • evaluate each different-net via pair once and emit only the most relevant error
  • preserve the existing drill-hole error when both manufacturing constraints fail
  • turn the reproduction from PR [codex] Add overlapping via pad short reproduction #213 into a passing regression with a visual DRC snapshot

Why

The existing different-net via spacing check measures drill-hole edge clearance. Two vias can therefore satisfy the drill rule while their larger copper annuli overlap or violate the board's pad-edge clearance. This stacked change folds the shared-layer annulus check into the same via-pair loop, checks it against min_pad_edge_to_pad_edge_clearance, and reports a standard pcb_pad_pad_clearance_error when the drill rule itself passes.

Stacked on #213; review that reproduction first.

Verification

  • bun test — 178 passed
  • bun run build
  • bunx tsc --noEmit
  • focused regression and visual SVG snapshot updated

@seveibar
seveibar marked this pull request as ready for review August 18, 2026 20:23
@seveibar
seveibar merged commit 863d6cb into codex/repro-overlapping-via-short Aug 18, 2026
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants