[codex] Detect different-net via pad clearance - #214
Merged
seveibar merged 2 commits intoAug 18, 2026
Merged
Conversation
seveibar
marked this pull request as ready for review
August 18, 2026 20:23
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkDifferentNetViaSpacingto check both drill-hole and copper-pad clearanceWhy
The existing different-net via spacing check measures drill-hole edge clearance. Two vias can therefore satisfy the drill rule while their larger copper annuli overlap or violate the board's pad-edge clearance. This stacked change folds the shared-layer annulus check into the same via-pair loop, checks it against
min_pad_edge_to_pad_edge_clearance, and reports a standardpcb_pad_pad_clearance_errorwhen the drill rule itself passes.Stacked on #213; review that reproduction first.
Verification
bun test— 178 passedbun run buildbunx tsc --noEmit