Fix leftover orbit neighbor parameters before 0.14.0 - #53
Merged
Conversation
One-orbit graphs were counting a dead K_nbr bank, which failed the isotypic-symmetry notebook capacity assertion on main. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/45_isotypic_symmetry.ipynbasserts that a one-orbit cycle has the same trainable count as a shared graph operator.K_nbr/K_hedgemodule registered beside the new per-orbit bank, so a cycle counted threed×dfactors instead of two._nbr/_hedgeto the orbit-0 representative. DualK_bwdand heteroK_rstay globally shared.Test plan
pytest tests/graph_utils/test_symmetry.py tests/operators/test_graph_operator.py::test_orbit_ties_keep_shared_backward_and_tie_forward tests/operators/test_hetero_orbits.py::test_multiplex_cycle_auto_orbits_single_orbit tests/operators/test_hypergraph_guards.py tests/operators/test_orbit_ties_guards.py27-46(includesexamples/45_isotypic_symmetry.ipynb)0.14.0/ releasev0.14.0Made with Cursor