Skip to content

refactor: send default fetch headers when resolving update downloads #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arthurschreiber merged 1 commit into from
Jul 19, 2026
Merged

refactor: send default fetch headers when resolving update downloads #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/main/index.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/main/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 1 addition & 8 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,14 +239,7 @@ export async function downloadUpdateInstaller(config: VersionConfig): Promise<st
// resolve download url
let downloadLink: string | null = null;
if (!config.updateUrl.endsWith('.exe')) {
// Use native fetch - the download page rejects requests made through
// @actions/http-client >= 3.0.1 with a 403, regardless of user agent.
const res = await fetch(config.updateUrl, {
headers: {
'accept': 'text/html,application/xhtml+xml',
'user-agent': 'tediousjs/setup-sqlserver (+https://github.com/tediousjs/setup-sqlserver)',
},
});
const res = await fetch(config.updateUrl);
if (res.ok) {
const body = await res.text();
const [, link] = body.match(/\s+href\s*=\s*["'](https:\/\/download\.microsoft\.com\/.*\.exe)['"]/) ?? [];
Expand Down