refactor: send default fetch headers when resolving update downloads#259
Merged
Conversation
The custom accept and user-agent headers are not needed - a probe from real Windows runners showed the update pages accept native fetch requests with any user agent, including the default. The default user agent also shares fate with all Node.js fetch users, making it less likely to be singled out by bot filtering than a tool-specific string. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
@dhensby PTAL. |
dhensby
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #258, which was merged while this simplification was still under discussion.
The custom
acceptanduser-agentheaders on the update-page request are not load-bearing: a probe from realwindows-2022/windows-2025runners showed the pages return 200 (with the download link present) for native fetch requests with any user agent — including the defaultnodeUA and even theactions/http-client actions_orchestration_id/...string that gets 403'd when sent through@actions/http-client— while acurlcontrol withaccept: */*also passed. The 403 keys on the http-client request shape, not the headers.Dropping the headers leaves a plain
fetch(config.updateUrl), and the default user agent shares fate with every Node.js fetch user, making it less likely to be singled out by future bot filtering than a tool-specific string (which is exactly how theactions/http-clientUA got blocked).Also removes the inline comment referencing
@actions/http-client— the context lives in #258 and the commit history.🤖 Generated with Claude Code