Techygeekshome patch 1 - #13
Merged
Merged
Conversation
App.axaml was carrying its own hardcoded palette inline - the older near-black/sky-blue set that the rest of the range moved off. The styles are in Themes/Shell.axaml now, reading Themes/Dark.axaml, which is the same token file DriverGeek, CleanGeek, DiskGeek and AppGeek carry.
Opening About went from the navy shell into a near-black dialog on its own palette - the most visible remaining seam in the range. Same values as Themes/Dark.axaml, 7px radii. The values stay literal rather than StaticResource: this is a library, and a StaticResource the host has not defined is a hard failure at load. The Ko-fi button keeps its own brand red on purpose. Identical change goes to DriverGeek and CleanGeek, which carry the same file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDFGeek was the last app in the range still on the older near-black/sky-blue set (#0b0b0d, #111113, #1f1f22, #38bdf8). It had no theme file at all - the control styles sat inline in App.axaml on their own hardcoded palette, and MainWindow carried a handful more.
Themes/Dark.axaml- the house tokens, copied from the other apps rather than re-derived.Themes/Shell.axaml- the styles that were inline in App.axaml, now reading those tokens. It merges the palette in its ownStyles.ResourcesbecauseApplication.Stylesis built beforeApplication.Resources, so a StaticResource lookup at app level cannot see it.TechyGeeksHome.Common/AboutWindow.axamlis on the same colours. Its values stay literal rather than StaticResource: this is a library, and a StaticResource the host has not defined is a hard failure at load. The Ko-fi button keeps its own brand red on purpose.Class names are deliberately unchanged - renaming them would be churn with no visual result. Converging the class vocabulary across the range is a separate pass.
Screens rendered headless from the real XAML to check, not assumed.