Fix null RT correction selection path - #771
Merged
YukiMatsuzawa merged 1 commit intoAug 17, 2026
Merged
Conversation
Read the RT correction peak selection path from ReferenceBaseParameter and handle missing paths safely when exporting parameters. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a null-handling bug during RT correction parameter serialization by ensuring the optional “RT correction peak selection file path” can be null without throwing, and by routing read/write access through ReferenceFileParam rather than a ParameterBase forwarding property.
Changes:
- Updated RT correction pipeline and console config parsing to use
parameter.ReferenceFileParam.RtCorrectionPeakSelectionFilePath. - Made
ParameterBase.ParametersAsText()null-safe when emitting the RT correction peak selection file path. - Removed the
ParameterBase.RtCorrectionPeakSelectionFilePathforwarding property in favor ofReferenceBaseParameterownership.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/MSDIAL5/MsdialCoreTestApp/Process/RetentionTimeCorrectionProcess.cs | Reads the selection path from ReferenceFileParam and uses a null-safe emptiness check before applying a selection file. |
| tests/MSDIAL5/MsdialCoreTestApp/Process/EicProcess.cs | Writes the selection path to ReferenceFileParam during RT correction setup. |
| tests/MSDIAL5/MsdialCoreTestApp/Parser/ConfigParser.cs | Parses the config key into ReferenceFileParam.RtCorrectionPeakSelectionFilePath to preserve configured behavior. |
| src/MSDIAL5/MsdialCore/Parameter/ParameterBase.cs | Removes the forwarding property and makes parameter text output null-safe for the selection path. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
YukiMatsuzawa
deleted the
bugfix/retentiontime-correction-parameter-is-null
branch
August 17, 2026 07:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RT correction can fail when the optional peak selection file path is null while
ParameterBase.ParametersAsText()serializes parameters. This change makes parameter output null-safe and keeps the path owned byReferenceBaseParameterinstead of exposing another forwarding property onParameterBase.The console configuration parser and RT correction process now read and write the path through
ReferenceFileParam, preserving the existing behavior for configured selection files.Validation:
dotnet build tests\MSDIAL5\MsdialCoreTestApp\MsdialCoreTestApp.csproj --no-restore --verbosity minimal