Skip to content

Expose a dedicated RT correction Console command - #774

Merged
YukiMatsuzawa merged 3 commits into
masterfrom
refactor/console-info-rtcorrection-command
Aug 19, 2026
Merged

Expose a dedicated RT correction Console command#774
YukiMatsuzawa merged 3 commits into
masterfrom
refactor/console-info-rtcorrection-command

Conversation

@htsugawa

@htsugawa htsugawa commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expose RT correction as the top-level rtcorrection command
  • retain eic rtcorrection as a hidden compatibility path
  • move RT correction implementation out of EicProcess into RtCorrectionProcess
  • remove the partial capabilities / info feature inventory; standard command help remains the single CLI discovery surface
  • add CLI structure and compatibility tests

Validation

  • Release/net8 build and tests: 0 errors; 6 tests passed
  • Release/net48 build: 0 errors
  • root help lists rtcorrection and does not list info or capabilities
  • rtcorrection --help succeeds; info and capabilities return exit code 1
  • Thermo RAW demo: top-level and legacy commands each exported 1,386 rows; CSV sizes and SHA-256 hashes were identical

DESKTOP-382ETUR\Hiroshi Tsugawa added 2 commits August 19, 2026 11:34
…fo-rtcorrection-command

# Conflicts:
#	tests/MSDIAL5/MsdialCoreTestApp/Process/EicProcess.cs
@htsugawa

Copy link
Copy Markdown
Contributor Author

Updated with the latest master and resolved the RT-correction selection-path conflict from #771 by using ReferenceFileParam.RtCorrectionPeakSelectionFilePath in the new RtCorrectionProcess. Revalidated Release/net8 and Release/net48 builds (0 errors), all 6 Console tests, and the Thermo RAW compatibility run: both command paths produced 1,386 rows and identical SHA-256 hashes.

@htsugawa htsugawa changed the title Clarify Console info and RT correction commands Expose a dedicated RT correction Console command Aug 19, 2026
@YukiMatsuzawa
YukiMatsuzawa merged commit 83c2db1 into master Aug 19, 2026
9 checks passed
@YukiMatsuzawa
YukiMatsuzawa deleted the refactor/console-info-rtcorrection-command branch August 19, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants