refactor: move XML shape metadata into smithy-xml extensions - #355
Open
jterapin wants to merge 7 commits into
Open
refactor: move XML shape metadata into smithy-xml extensions#355jterapin wants to merge 7 commits into
jterapin wants to merge 7 commits into
Conversation
jterapin
force-pushed
the
schema-extensions-xml
branch
from
August 20, 2026 16:06
73dcc15 to
d1e362f
Compare
jterapin
marked this pull request as ready for review
August 20, 2026 16:26
jterapin
force-pushed
the
schema-extensions-xml
branch
from
August 20, 2026 19:20
7621e38 to
146a8f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is the third PR in the stack and should be reviewed on top of #353.
PR #353 moved JSON and CBOR wire-name resolution into protocol-specific extensions and normalized generated runtime metadata around
model_nameand symbolized serde traits. This follow-up does the same cleanup for XML: move XML-specific metadata and lookup logic intoSmithy::Xml::Extensionwhile keepingrestXmlbehavior stable.What changed
Smithy::Xml::Extensionhelpers for XML serde metadata derived from Smithy traits.@xmlNametrait.@xmlAttributetrait.@xmlNamespacetrait.model_nameand symbolized serde traits consistently.Non-goals
Testing
bundle exec rspec gems/smithy-xml/spec/smithy-xml/extension_spec.rb gems/smithy-xml/spec/smithy-xml/builder_spec.rbbundle exec rspec gems/smithy/spec/interfaces/schema/serde_traits_spec.rbbundle exec rake test:protocols:restXmlinaws-sdk-ruby-staging256 examples, 0 failures, 2 pending--
Written with AI assistance and reviewed by jterapin.