refactor: remove MemberShape location_name alias and regenerate projections - #356
Open
jterapin wants to merge 3 commits into
Open
refactor: remove MemberShape location_name alias and regenerate projections#356jterapin wants to merge 3 commits into
jterapin wants to merge 3 commits into
Conversation
jterapin
marked this pull request as ready for review
August 20, 2026 16:56
jterapin
force-pushed
the
schema-extensions-regenerate
branch
from
August 20, 2026 19:21
ab3e7ec to
c876c24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Stacked on #355.
The earlier schema extension PRs moved runtime serde toward
model_namewhile keepinglocation_nameas a temporary compatibility alias onMemberShape. This follow-up removes that alias inside smithy-ruby and updates the checked-in generated projections to emitmodel_name.What changed
location_namefallback and alias fromSmithy::Schema::Shapes::MemberShapelocation_namemodel_namemodel_nameScope
This PR is intentionally limited to smithy-ruby and its checked-in projections.
Out of scope for this PR:
aws-sdk-coreruntime call sites that still referencelocation_namelocation_nameTesting
bundle exec smithy build --debugbundle exec rspec gems/smithy-schema/spec/smithy-schema/shapes_spec.rbbundle exec rspec gems/smithy/spec/interfaces/schema/serde_traits_spec.rbbundle exec rspec gems/smithy-client/spec/smithy-client/plugins/host_prefix_spec.rbbundle exec rspec gems/smithy-client/spec/smithy-client/plugins/stub_responses_spec.rbbundle exec rake smithy-cbor:spec smithy-client:spec smithy-json:spec smithy-schema:spec smithy-xml:spec smithy:spec--
Written with AI assistance and reviewed by jterapin.