Add macOS support - #7
Merged
Merged
Conversation
And remove the macOS symlink hack.
Also, mount images at an explicit path instead of parsing hdiutil output.
Closed
There was a problem hiding this comment.
🟡 Changes recommended
Architecture gating, non-atomic app extraction, and reduced MSRV coverage need correction.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds macOS support for downloading, extracting, and running Electrum.
Changes:
- Adds DMG download/extraction and platform-specific executable paths.
- Adds macOS checksums and CI coverage.
- Updates CI runners and Rust-version coverage.
File summaries
| File | Description |
|---|---|
build.rs |
Downloads and extracts macOS DMGs. |
src/lib.rs |
Uses platform-specific executable paths. |
src/versions.rs |
Defines Linux and macOS executable paths. |
.github/workflows/test.yml |
Adds macOS CI and updates runners. |
sha256/electrum-4.1.5.dmg-SHA256SUM |
Adds macOS checksum. |
sha256/electrum-4.1.5-x86_64.AppImage-SHA256SUM |
Adds Linux checksum. |
sha256/electrum-4.5.4.dmg-SHA256SUM |
Adds macOS checksum. |
sha256/electrum-4.5.4-x86_64.AppImage-SHA256SUM |
Adds Linux checksum. |
sha256/electrum-4.6.2.dmg-SHA256SUM |
Adds macOS checksum. |
sha256/electrum-4.6.2-x86_64.AppImage-SHA256SUM |
Adds Linux checksum. |
sha256/electrum-4.7.0.dmg-SHA256SUM |
Adds macOS checksum. |
sha256/electrum-4.7.0-x86_64.AppImage-SHA256SUM |
Adds Linux checksum. |
Review details
- Files reviewed: 8/12 changed files
- Comments generated: 4
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| fail-fast: false | ||
| matrix: | ||
| toolchain: [ "1.70", "stable", "nightly" ] | ||
| toolchain: [ "1.88", "stable", "nightly" ] |
Comment on lines
+17
to
+19
| #[cfg(target_os = "macos")] | ||
| fn download_filename() -> String { | ||
| format!("electrum-{}.dmg", &VERSION) |
Comment on lines
+96
to
+106
| let app_dest = download_dir.join("Electrum.app"); | ||
| let app_src = mounted_dmg.0.join("Electrum.app"); | ||
| let cp_output = std::process::Command::new("cp") | ||
| .args(["-R", app_src.to_str().unwrap(), app_dest.to_str().unwrap()]) | ||
| .output() | ||
| .expect("failed to copy Electrum.app"); | ||
| assert!( | ||
| cp_output.status.success(), | ||
| "cp -R failed: {}", | ||
| String::from_utf8_lossy(&cp_output.stderr) | ||
| ); |
Comment on lines
+11
to
+12
| #[cfg(target_os = "macos")] | ||
| pub const EXE_REL_PATH: &str = "Electrum.app/Contents/MacOS/run_electrum"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.