Added mac support - #6
Closed
shesek wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The DMG lacks integrity verification, mount cleanup is unreliable, and the macOS path is untested in CI.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds native macOS support for downloading and launching Electrum.
Changes:
- Downloads and mounts the Electrum DMG.
- Copies
Electrum.appand exposes its executable through the existing path.
File summaries
| File | Description |
|---|---|
build.rs |
Adds macOS artifact installation logic. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+69
to
+72
| #[cfg(target_os = "macos")] | ||
| { | ||
| let dmg_path = download_dir.join("electrum.dmg"); | ||
| fs::write(&dmg_path, &downloaded_bytes).unwrap(); |
Comment on lines
+97
to
+101
| let cp_output = std::process::Command::new("cp") | ||
| .args(["-R", app_src.to_str().unwrap(), app_dest.to_str().unwrap()]) | ||
| .output() | ||
| .expect("failed to copy Electrum.app"); | ||
| assert!( |
| fs::write(&filepath, downloaded_bytes).unwrap(); | ||
| } | ||
|
|
||
| #[cfg(target_os = "macos")] |
Owner
Author
|
--> #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.