Skip to content

Turn all tests into integration tests - #495

Merged
alejandro-vaz merged 1 commit into
servo:v2from
TDecking:integration-tests
Aug 29, 2026
Merged

Turn all tests into integration tests#495
alejandro-vaz merged 1 commit into
servo:v2from
TDecking:integration-tests

Conversation

@TDecking

Copy link
Copy Markdown
Contributor

For now, the bare minimum regarding #440.

Later PRs will do a couple of overhauls to the test suite.

@alejandro-vaz

alejandro-vaz commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

a few notes for future changes:

  • keep draining tests/main.rs
  • remove the test_ prefix on all test names
  • get rid of test-level imports, have them all top-of-the-file (they were previously needed because we had all in one file, now we link conditionally)
  • either have all the tests with #[should_panic] include a reason, or make them all not have a reason, but have it consistent
  • the codebase is getting uncomfortably large, we have to try to get rid of unnecessary stuff and simplify

this PR looks good

@alejandro-vaz
alejandro-vaz added this pull request to the merge queue Aug 29, 2026
Merged via the queue into servo:v2 with commit 9c9ee2f Aug 29, 2026
6 checks passed
@TDecking
TDecking deleted the integration-tests branch August 29, 2026 23:14
@alejandro-vaz alejandro-vaz linked an issue Aug 29, 2026 that may be closed by this pull request
@alejandro-vaz

Copy link
Copy Markdown
Collaborator

also, you can assign yourself to issues now by commenting on any issue smallbot! assign

it's all on the wiki if you want to take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

initial move from src/tests.rs to tests/*.rs

2 participants