Implement arbitrary::Arbitrary for SmallVec - #496
Merged
Conversation
Jorge-Polanco-Roque
added a commit
to Jorge-Polanco-Roque/contribution-pipeline
that referenced
this pull request
Aug 29, 2026
Afinado el pipeline para colaborar en repos reales, con tests en el sandbox y un primer PR real abierto: - tools/recon.sh: reconocimiento de repos (profile/find/issues/ci/t1) con veredicto GO/MAYBE/SKIP (≥100★), salud fina (merges/30d, externos, DCO, task-runner), y extracción de comandos del CI (paridad). T1 5/5 sobre repos conocidos. - tools/pre_submit.sh: modo --parity (reproduce el CI del repo) + risk-scan del diff. - arena/agents/referee.md: capa social (rondas de review). Contributor: sign-off + respetar CONTRIBUTING + declinar issues ambiguos. - LAUNCH-PLAN.md: gaps + tests (T1–T6) + ruta gradual R0→R4 + guardrails (≥100★, agentes redactan / accionista publica). - arena/CHALLENGES.md: 10 retos hyper-experto (auditoría de puntos ciegos del gate). - LEARNINGS.md: T6 cazó una mis-selección (#9060, `[lib] test=false`) ANTES de un PR; re-selección verificada → contribución limpia. Primera contribución real: - contributions/active/C001: servo/rust-smallvec#496 — impl `arbitrary::Arbitrary` for `SmallVec` (closes #494). Enviado, esperando review. - README/DASHBOARD: sección de contribuciones reales + métricas (PRs enviados 0→1). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>
alejandro-vaz
self-requested a review
August 29, 2026 23:04
alejandro-vaz
requested changes
Aug 29, 2026
Collaborator
|
also, I merged #495 before this PR, my mistake, there are now merge conflicts simply sync your fork, fetch from v2, and your branch rebase onto it so basically after that you have to create a |
Ports the implementation from the v1 branch to the v2 `SmallVec<T, const N>` API, gated behind a new optional `arbitrary` feature. Delegates to `Unstructured::arbitrary_iter` / `arbitrary_take_rest_iter` and collects via the existing `FromIterator` impl. Adds a feature-gated test. Closes servo#494 Signed-off-by: Jorge Polanco <55784702+Jorge-Polanco-Roque@users.noreply.github.com>
Jorge-Polanco-Roque
force-pushed
the
feat/arbitrary-impl
branch
from
August 29, 2026 23:26
17dcd93 to
cf64036
Compare
Contributor
Author
|
Thanks for the review! Addressed all points:
|
alejandro-vaz
enabled auto-merge
August 29, 2026 23:36
alejandro-vaz
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #494.
Ports the implementation from the v1 branch to the v2
SmallVec<T, const N>API, behind a new optionalarbitraryfeature (gated the same way asserde).arbitrary/arbitrary_take_restdelegate toUnstructured::arbitrary_iter/arbitrary_take_rest_iterand collect via the existingFromIteratorimpl.size_hintmirrors the standard sequence implementation.test_arbitrary).Verified locally:
cargo build --features arbitrary,cargo test --features arbitrary(new test passes), andcargo fmt --checkare all green.