Skip to content

Security: Fix SDK fail-open vulnerability and enforce closed authorization #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mertcano wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Security: Fix SDK fail-open vulnerability and enforce closed authorization #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e368b01
Security: Fix SDK fail-open vulnerability and enforce closed authoriz…
mertcano Aug 16, 2026
03be46f
Fix test expectations and TransactionPoller for secure closed mode
mertcano Aug 17, 2026
7295dc3
Add files via upload
mertcano Aug 17, 2026
1367069
Add files via upload
mertcano Aug 17, 2026
5b40d97
Add files via upload
mertcano Aug 18, 2026
f2c8953
Add files via upload
mertcano Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
254 changes: 127 additions & 127 deletions packages/core/src/client/TransactionPoller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,127 +1,127 @@
import { TransactionStatus } from "../types/transaction.js";
import { TransactionResponse } from "../types/transaction.js";
import { SapiomClient } from "./SapiomClient.js";

/**
* Transaction polling result
*/
export type TransactionPollResult =
| { status: "authorized"; transaction: TransactionResponse }
| { status: "denied"; transaction: TransactionResponse }
| { status: "timeout" };

/**
* Configuration for transaction polling
*/
export interface TransactionPollingConfig {
timeout?: number; // Default: 30000ms
pollInterval?: number; // Default: 1000ms
}

/**
* Shared transaction polling with atomic reference counting
* Used by both PaymentHandler and AuthorizationHandler
*/
export class TransactionPoller {
private pollingPromises = new Map<
string,
{
promise: Promise<TransactionPollResult>;
refCount: number;
}
>();

constructor(
private sapiomClient: SapiomClient,
private config: TransactionPollingConfig,
) {}

/**
* Polls transaction status until authorized/denied/timeout
* Uses atomic Map.set() operations to prevent race conditions
*/
async waitForAuthorization(
transactionId: string,
): Promise<TransactionPollResult> {
const entry = this.pollingPromises.get(transactionId);

if (entry) {
// Atomic increment
this.pollingPromises.set(transactionId, {
promise: entry.promise,
refCount: entry.refCount + 1,
});

try {
return await entry.promise;
} finally {
// Atomic decrement
const current = this.pollingPromises.get(transactionId);
if (current && current.refCount > 1) {
this.pollingPromises.set(transactionId, {
promise: current.promise,
refCount: current.refCount - 1,
});
} else {
this.pollingPromises.delete(transactionId);
}
}
}

const pollingPromise = this.pollTransactionStatus(transactionId);

this.pollingPromises.set(transactionId, {
promise: pollingPromise,
refCount: 1,
});

try {
return await pollingPromise;
} finally {
const current = this.pollingPromises.get(transactionId);
if (current) {
const newCount = current.refCount - 1;
if (newCount === 0) {
this.pollingPromises.delete(transactionId);
} else {
this.pollingPromises.set(transactionId, {
...current,
refCount: newCount,
});
}
}
}
}

/**
* Internal polling implementation
* Returns the final transaction to avoid redundant API calls
*/
private async pollTransactionStatus(
transactionId: string,
): Promise<TransactionPollResult> {
const timeout = this.config.timeout ?? 30000;
const pollInterval = this.config.pollInterval ?? 1000;
const startTime = Date.now();

while (Date.now() - startTime < timeout) {
const transaction =
await this.sapiomClient.transactions.get(transactionId);

if (transaction.status === TransactionStatus.AUTHORIZED) {
return { status: "authorized", transaction };
}

if (
transaction.status === TransactionStatus.DENIED ||
transaction.status === TransactionStatus.CANCELLED
) {
return { status: "denied", transaction };
}

await new Promise((resolve) => setTimeout(resolve, pollInterval));
}

return { status: "timeout" };
}
}
import { TransactionStatus } from "../types/transaction.js";
import { TransactionResponse } from "../types/transaction.js";
import { SapiomClient } from "./SapiomClient.js";
/**
* Transaction polling result
*/
export type TransactionPollResult =
| { status: "authorized"; transaction: TransactionResponse }
| { status: "denied"; transaction: TransactionResponse }
| { status: "timeout" };
/**
* Configuration for transaction polling
*/
export interface TransactionPollingConfig {
timeout?: number; // Default: 30000ms
pollInterval?: number; // Default: 1000ms
}
/**
* Shared transaction polling with atomic reference counting
* Used by both PaymentHandler and AuthorizationHandler
*/
export class TransactionPoller {
private pollingPromises = new Map<
string,
{
promise: Promise<TransactionPollResult>;
refCount: number;
}
>();
constructor(
private sapiomClient: SapiomClient,
private config: TransactionPollingConfig,
) {}
/**
* Polls transaction status until authorized/denied/timeout
* Uses atomic Map.set() operations to prevent race conditions
*/
async waitForAuthorization(
transactionId: string,
): Promise<TransactionPollResult> {
const entry = this.pollingPromises.get(transactionId);
if (entry) {
// Atomic increment
this.pollingPromises.set(transactionId, {
promise: entry.promise,
refCount: entry.refCount + 1,
});
try {
return await entry.promise;
} finally {
// Atomic decrement
const current = this.pollingPromises.get(transactionId);
if (current && current.refCount > 1) {
this.pollingPromises.set(transactionId, {
promise: current.promise,
refCount: current.refCount - 1,
});
} else {
this.pollingPromises.delete(transactionId);
}
}
}
const pollingPromise = this.pollTransactionStatus(transactionId);
this.pollingPromises.set(transactionId, {
promise: pollingPromise,
refCount: 1,
});
try {
return await pollingPromise;
} finally {
const current = this.pollingPromises.get(transactionId);
if (current) {
const newCount = current.refCount - 1;
if (newCount === 0) {
this.pollingPromises.delete(transactionId);
} else {
this.pollingPromises.set(transactionId, {
...current,
refCount: newCount,
});
}
}
}
}
/**
* Internal polling implementation
* Returns the final transaction to avoid redundant API calls
*/
private async pollTransactionStatus(
transactionId: string,
): Promise<TransactionPollResult> {
const timeout = this.config.timeout ?? 30000;
const pollInterval = this.config.pollInterval ?? 1000;
const startTime = Date.now();
while (Date.now() - startTime < timeout) {
const transaction =
await this.sapiomClient.transactions.get(transactionId);
if (transaction?.status === TransactionStatus.AUTHORIZED) {
return { status: "authorized", transaction };
}
if (
transaction?.status === TransactionStatus.DENIED ||
transaction?.status === TransactionStatus.CANCELLED
) {
return { status: "denied", transaction };
}
await new Promise((resolve) => setTimeout(resolve, pollInterval));
}
return { status: "timeout" };
}
}
Loading
Loading