Security: Fix SDK fail-open vulnerability and enforce closed authorization - #642
Open
mertcano wants to merge 6 commits into
Open
Security: Fix SDK fail-open vulnerability and enforce closed authorization#642mertcano wants to merge 6 commits into
mertcano wants to merge 6 commits into
Conversation
…ation This PR patches a HIGH-severity vulnerability in the SDK's transport/authentication layer where control-plane outages or authorization failures caused the SDK to default to an "open" failure mode (failureMode: "open"). This allowed unverified requests to bypass governance bounds and directly consume backend services. The default behavior is now strictly locked to "closed" and fail-open opt-ins are disabled for payment-protected endpoints. Changes: Secure Defaults: Changed the default failureMode in both @sapiom/fetch (createFetch) and @sapiom/node-http (createClient) adapters from "open" to "closed" to enforce secure defaults for all governed clients. Payment-Protected Opt-Out Override: Updated interceptors.ts to calculate an effectiveFailureMode. If userMetadata?.paymentProtected is true, or if the flow has entered the handlePayment (HTTP 402) handler, the failure mode is forcibly set to "closed". This ensures it is impossible to explicitly opt-in to availability-first behavior for endpoints protected by a payment/budget boundary.
github-actions
Bot
added
contribution: incomplete
mertcano
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR patches a HIGH-severity vulnerability in the SDK's transport/authentication layer where control-plane outages or authorization failures caused the SDK to default to an "open" failure mode (failureMode: "open"). This allowed unverified requests to bypass governance bounds and directly consume backend services. The default behavior is now strictly locked to "closed" and fail-open opt-ins are disabled for payment-protected endpoints.
Changes:
Secure Defaults: Changed the default failureMode in both @sapiom/fetch (createFetch) and @sapiom/node-http (createClient) adapters from "open" to "closed" to enforce secure defaults for all governed clients.
Payment-Protected Opt-Out Override: Updated interceptors.ts to calculate an effectiveFailureMode. If userMetadata?.paymentProtected is true, or if the flow has entered the handlePayment (HTTP 402) handler, the failure mode is forcibly set to "closed". This ensures it is impossible to explicitly opt-in to availability-first behavior for endpoints protected by a payment/budget boundary.