refactor: remove bench tier (imu_attitude relocated to xmAppBotBench) - #40
Merged
Conversation
The hardware bench (imu_attitude) links xmDriver + xmNavigation + quickviz, which ADR-0005 reserves for application repos, not the umbrella (the family ships libraries, not apps). It now lives in its own app repo, rxdu/xmAppBotBench. Removes bench/, the XMOTION_BUILD_BENCH option + add_subdirectory(bench), and repoints the ROADMAP IMU-bench item at xmAppBotBench. No library targets are affected (the tier was opt-in, OFF by default).
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardware bench
bench/imu_attitudelinks xmDriver + xmNavigation + quickviz — the exact composition ADR-0005 reserves for application repos, not the umbrella (the family ships libraries, not apps). It has been relocated to its own app repo, rxdu/xmAppBotBench, where it builds against the same components as pinned submodules.This removes it from the umbrella:
bench/(CMakeLists + imu_attitude station)XMOTION_BUILD_BENCHoption andadd_subdirectory(bench)in the top CMakeListsROADMAP.mdIMU-bench item at xmAppBotBenchNo library targets are affected — the bench tier was opt-in and OFF by default. Umbrella still configures cleanly.
Context: the bench originally landed on main via
4118edf; the relocation to xmAppBotBench copied it out, and this closes the loop by removing the umbrella copy.