fix: exclude grace-period ghosts from tree kill - #7
Merged
Conversation
Stabilizer rows that have already exited were still included in TERM/KILL tree planning and family counts, so ProcessKiller failed closed for ~2.5s after any child exit. Also correct approved-root path checks when root is "/".
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
TERM Tree / force-kill tree and family descendant counts now use live process rows only, so recently exited grace-period PIDs no longer cause false
targetNotRunningfailures or inflated tree counts. Approved-path authorization also correctly handles filesystem root (/) instead of building a broken//prefix.Related issue
None — found during end-to-end audit. Companion private-fork PR: https://github.com/s1korrrr/devscope/pull/20 (blocked there by Actions budget).
Change type
Risk and boundaries
/handling corrected for latent helper correctness.Breaking-change impact
None. Adds
ProcessPresentation.liveScopedTreeInputs(pre-1.0 unstable library surface).Verification
build_and_run.sh --verifyTest plan