fix: harden lsof, denylist, and crontab gating - #8
Merged
Conversation
Parse lsof CWD fields with NUL terminators to block newline injection, expand session-critical process protection with path prefixes, and gate crontab mutation on verified write/readback to match SECURITY_STATUS.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Closes residual audit hardenings: NUL-terminated
lsofCWD parsing (newline field injection), tighter session-critical process denylist with CoreServices/libexec path prefixes, and crontab mutation capability gating on verified write/readback aligned withSECURITY_STATUS.Related issue
Follow-up to the end-to-end audit that shipped tree-kill / path-auth in #7.
Change type
Risk and boundaries
/System/Library/CoreServices/+/usr/libexec/); developer tools under Homebrew//optremain killable.lsofnow uses-F pcn0; CWD paths with embedded newlines parse safely.Breaking-change impact
None for app users.
AutomationCapabilityContextgainsmutableSourceVerified(defaulttrue).Verification
./script/check_open_source_readiness.shswift test -Xswiftc -warnings-as-errors(679 tests, 0 failures)swift build -c release -Xswiftc -warnings-as-errorsbash -n script/*.sh./script/build_and_run.sh --verifyEvidence
lsofnewline paths, session-critical denylist, crontabmutableSourceVerifiedgating, mutation probe unit testsbuild_and_run.sh --verifyOK; sandboxvalidate_release_bundle.shOKTest plan