Skip to content

[ExecuTorch][WebGPU] Add split_with_sizes_copy op#20995

Open
JCNTH wants to merge 2 commits into
gh/JCNTH/99/basefrom
gh/JCNTH/99/head
Open

[ExecuTorch][WebGPU] Add split_with_sizes_copy op#20995
JCNTH wants to merge 2 commits into
gh/JCNTH/99/basefrom
gh/JCNTH/99/head

Conversation

@JCNTH

@JCNTH JCNTH commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Add aten.split_with_sizes_copy.default to the WebGPU backend — the split on YOLO's Detect head (separating the concatenated box / objectness / class predictions).

Problem: The WebGPU delegate had no split_with_sizes_copy, so YOLO object-detection could not fully delegate to the GPU.

Solution: Split self along dim into N contiguous chunks. Each chunk is a step-1 slice from the running offset, reusing the slice.wgsl gather kernel — one dispatch per output. Outputs arrive as a serialized ValueList. Each chunk writes its own distinct output buffer and reads only the shared input, so there is no cross-dispatch read-after-write hazard.

Implementation:

  • runtime/ops/split_with_sizes/SplitWithSizes.cpp registering aten.split_with_sizes_copy.default; reuses slice_wgsl.h (no new shader). Uses utils::make_compute_pipeline (auto-derived bind-group layout) rather than hand-rolling the layout / pipeline / bind group.
  • Mirrors the Vulkan split_with_sizes_copy delegate.
  • CMake WEBGPU_SRCS entry.

Constraints: fp32-only; dim normalized + range-checked; outputs == sizes count enforced (fail-loud). Reuses the slice op's slice_wgsl.h, so this diff stacks above slice and must land after it. No change to existing ops.

Differential Revision: D112417284

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20995

Note: Links to docs will display an error until the docs builds have been completed.

❌ 128 New Failures, 3 Unrelated Failures, 7 Unclassified Failures

As of commit d53a8f6 with merge base c2b273e (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

  • pull / unittest / windows / windows-job (gh) (matched win rule in flaky-rules.json)
    Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under 'C:\actions-runner\_work\executorch\executorch\test-infra\.github\actions\teardown-windows'. Did you forget to run actions/checkout before running your local action?
  • pull / unittest-editable / windows / windows-job (gh) (matched win rule in flaky-rules.json)
    Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under 'C:\actions-runner\_work\executorch\executorch\test-infra\.github\actions\teardown-windows'. Did you forget to run actions/checkout before running your local action?

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This was referenced Jul 16, 2026
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2026
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants