Skip to content

[ExecuTorch][WebGPU] Add leaky_relu op#20989

Open
JCNTH wants to merge 2 commits into
gh/JCNTH/93/basefrom
gh/JCNTH/93/head
Open

[ExecuTorch][WebGPU] Add leaky_relu op#20989
JCNTH wants to merge 2 commits into
gh/JCNTH/93/basefrom
gh/JCNTH/93/head

Conversation

@JCNTH

@JCNTH JCNTH commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Add aten.leaky_relu.default to the WebGPU backend — the SRVGGNetCompact body activation in Real-ESRGAN x4plus super-resolution, so that model can fully delegate to the GPU.

Problem: The WebGPU delegate had no leaky_relu handler, so a model using it could not produce a fully-delegated .pte.

Solution: A scalar-parameter elementwise fp32 kernel computing x >= 0 ? x : negative_slope * x, with negative_slope carried in the uniform and a 2D-spill dispatch for tensors exceeding the 1D workgroup-count limit.

Implementation:

  • runtime/ops/leaky_relu/{LeakyRelu.cpp,leaky_relu.wgsl,leaky_relu_wgsl.h} registering aten.leaky_relu.default; uses utils::make_compute_pipeline + utils::compute_dispatch_grid.
  • Mirrors the Vulkan leaky_relu.default delegate (scalar-in-uniform, like pow.Tensor_Scalar).
  • CMake WEBGPU_SRCS entry.

Constraints: fp32-only — throws on non-fp32 or input/output size mismatch (fail-loud, never a silent zero output); no change to existing ops.

Differential Revision: D112417289

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20989

Note: Links to docs will display an error until the docs builds have been completed.

❌ 128 New Failures, 3 Unrelated Failures, 7 Unclassified Failures

As of commit 5ab70af with merge base c2b273e (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

  • pull / unittest / windows / windows-job (gh) (matched win rule in flaky-rules.json)
    Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under 'C:\actions-runner\_work\executorch\executorch\test-infra\.github\actions\teardown-windows'. Did you forget to run actions/checkout before running your local action?
  • pull / unittest-editable / windows / windows-job (gh) (matched win rule in flaky-rules.json)
    Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under 'C:\actions-runner\_work\executorch\executorch\test-infra\.github\actions\teardown-windows'. Did you forget to run actions/checkout before running your local action?

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This was referenced Jul 16, 2026
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant