Conversation
Comment on lines
+101
to
+111
| function setGateColumn(ref: SUniversalPColumnId | undefined) { | ||
| app.model.data.gateColumnRef = ref; | ||
| app.model.data.gateValues = valuesFor(ref); | ||
| // The label too: only the option list knows it, and the block subtitle is derived from | ||
| // `data` alone. Same gesture, so no watcher on an output is needed. | ||
| app.model.data.gateColumnLabel = app.model.outputs.gateOptions?.find( | ||
| (option) => option.value === ref, | ||
| )?.label; | ||
| // Seed the order with the column's own values. A different gate column has different | ||
| // values, so any previous ordering is meaningless. | ||
| app.model.data.gateOrder = valuesFor(ref); |
There was a problem hiding this comment.
Async value snapshot breaks selection
When a user selects a metadata column before useWatchFetch has populated valuesByRef, valuesFor(ref) returns an empty array and the handlers persist that as the column snapshot. For a gate column, this hides the ordering control and leaves Run disabled with “The gate column has no values to rank” until the user clears or reselects the column after loading completes.
Prompt To Fix With AI
This is a comment left during a code review.
Path: ui/src/components/SettingsDrawer.vue
Line: 101-111
Comment:
**Async value snapshot breaks selection**
When a user selects a metadata column before `useWatchFetch` has populated `valuesByRef`, `valuesFor(ref)` returns an empty array and the handlers persist that as the column snapshot. For a gate column, this hides the ordering control and leaves Run disabled with “The gate column has no values to rank” until the user clears or reselects the column after loading completes.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec
Greptile Summary
The PR implements an end-to-end FACS sort-seq analysis block, including Python scoring, Tengo orchestration, Platforma model contracts, Vue result views, packaging, and CI. Important touched terms:
pl7.app/facsBin/gateRankMean.pl7.app/facsBin/binScore, with referenced, cancelled, and absent-parent-output handling.Confidence Score: 4/5
The PR should not merge until gate and condition selections cannot persist empty snapshots while their metadata values are still loading; the stale README status is non-blocking but should also be corrected.
The settings UI exposes selectable metadata before its independent asynchronous value fetch is guaranteed complete, so a valid gate selection can be saved with no values and leave the block unrunnable until manually reselected.
Files Needing Attention: ui/src/components/SettingsDrawer.vue; README.md
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Upstream abundance and metadata columns] --> B[Model settings and validation] B --> C[Tengo workflow exports reads and variants] C --> D[Python validation and scoring] D --> E[Score, distribution, and manifest files] E --> F[Tengo constructs Platforma columns] F --> G[Results table] F --> H[Condition distribution charts] E --> I[Run statistics]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "FACS Analysis block implementation" | Re-trigger Greptile
Context used: