Skip to content

Json schema: remove Variants and Tuples as they're removed in yojson 3.0.0 #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ElectreAAS wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −4
Draft

Json schema: remove Variants and Tuples as they're removed in yojson 3.0.0 #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pipeline/cb-schema/json.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ type t =
| `Float of float
| `String of string
| `Assoc of (string * t) list
| `List of t list
| `Tuple of t list
| `Variant of string * t option ]
| `List of t list ]

let error key value_type value =
match value with
Expand Down
2 changes: 1 addition & 1 deletion pipeline/cb-schema/schema.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ let result_of_json t lines =
let of_json t =
let lines =
match Json.get_opt "lines" t with
| `Tuple [ `Int start; `Int finish ] -> [ (start, finish) ]
| `List [ `Int start; `Int finish ] -> [ (start, finish) ]
| _ -> []
in
{
Expand Down