feat(viewer): let a caller turn the sidebar off - #13
Merged
Conversation
Registering the built-in handlers on import made the entry call into
lib/models, which imports registerHandler back from the entry. Entering
the graph through a model rather than through the entry then reached the
entry mid-evaluation and called a handler module that had not run yet:
Cannot access '__vite_ssr_import_2__' before initialization
The registry, the file actions and IHandler move to lib/handlers.ts,
which the models import instead. The entry keeps its exports and is now
only what it does on import: offer this copy, hold the service, register
the defaults.
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
The modal title, the document title, the comparison header, the image alt text and the editor label all read the basename. A node can carry a display name that differs from it — a file version is served under its version id and reads as the date it was taken — and then every one of those showed a number. Node.displayname falls back to the basename, so nothing changes for a node without one. Renaming still works on the basename, which is what it edits. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
The Files sidebar resolves a file by its dav source, so it can only be opened for a file the Files app can find there. An old version of a file is served from the versions endpoint and is not one of those: the button is offered and does nothing. enableSidebar, defaulting to true, is what the old OCA.Viewer API had for this, and the versions sidebar in the server needs it back to port. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 72.03% 72.41% +0.38%
==========================================
Files 33 34 +1
Lines 2285 2302 +17
Branches 377 382 +5
==========================================
+ Hits 1646 1667 +21
+ Misses 633 629 -4
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Files sidebar resolves a file by its dav source, so it can only be opened for a file the Files app can find there. An old version of a file is served from the versions endpoint and is not one of those — the button shows and does nothing.
enableSidebar, defaulting to true, is what the oldOCA.ViewerAPI had for exactly this, and the versions sidebar in the server needs it back to port off that global (nextcloud/server#63954).Stacked on #12, which is stacked on #11.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.