Extend npm protected mutation path guards - #198
Merged
Conversation
newtv-ai
marked this pull request as ready for review
August 23, 2026 18:44
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up #197 by extending npm vendor-mutation overlap protection to additional source-backed persistent/security path configuration.
Current npm exposes long-lived path-valued inputs beyond
prefix,userconfig, andlogs-dir, includingglobalconfig,cafile,init-module/init.module, andnode-gyp; npm 12 additionally exposes the user-ownedglobal-ignore-file. If any of these is redirected inside_cacacheor an exact npx entry, npm's recursive vendor command would otherwise be broader than the mutation scope DevClean presents.Change
global-ignore-fileadditionally for npm 12+ so older npm is not failed merely for lacking a newer key.Non-goals
No rule ownership/lane changes, no raw filesystem TOOL roots, no new deletion authority, no UI changes, and no generic-scan pruning. The npm scan-performance audit remains separate.
Audit:
docs/npm-persistent-path-overlap-followup-audit.md.Merge gate
Merge only from the exact final head after lock/dependency checks, Ruff, strict mypy, full pytest, Windows EXE build/upload, and CodeQL are all green.