Prune source-proven npm cache children from generic scans - #199
Merged
Conversation
newtv-ai
marked this pull request as ready for review
August 23, 2026 19:01
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid redundant generic per-file traversal of the exact npm provider children
_cacache,_npx, and_tufwhile preserving diagnostic, unknown, redirected, and filesystem-boundary visibility.Change
npm_generic_scan_skip_paths()proof using the bound npm CLI, live version-aware config, exact source rules, and stable local filesystem identities._logsor unclassified cache-root state.npm cache ls,npm cache npx ls, recursive size inventory, or any mutation command for scan pruning.Non-goals
No TOOL/USER/KEEP lane changes, no raw npm filesystem authority, no new cleanup action, no npm reclaim quantification, no whole-cache category pruning, and no mutation-command changes.
Audit:
docs/npm-source-proven-scan-pruning-audit.md.Merge gate
Merge only from the exact final head after lock/dependency checks, Ruff, strict mypy, full pytest, Windows EXE build/upload, and CodeQL are all green.