Fix gh-aw v0.86.2 safe-output base parsing - #19445
Fix gh-aw v0.86.2 safe-output base parsing#19445David Pine (IEvangelist) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32c349b4-907d-42e9-aad8-2f0edc267779
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19445Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19445" |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Fixes gh-aw v0.86.2 parsing of documentation PR target branches while retaining legacy compatibility.
Changes:
- Accepts
baseand legacybase_branch, rejecting conflicts. - Regenerates the compiled workflow and updates structural tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/pr-docs-check.md |
Updates target-branch resolution. |
.github/workflows/pr-docs-check.lock.yml |
Regenerates the compiled workflow. |
tests/Infrastructure.Tests/WorkflowScripts/PrDocsCheckWorkflowTests.cs |
Updates workflow assertions. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32c349b4-907d-42e9-aad8-2f0edc267779
This comment has been minimized.
This comment has been minimized.
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Preserve strict support for current base and legacy base_branch target fields after #19446. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32c349b4-907d-42e9-aad8-2f0edc267779
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 1 / 101 test projects · 0 jobs, from 5 changed files. Selected test projects (1 / 101)
Selected jobs (0)none How these were chosen — grouped by what changed📄 📄 📄 📄 🧪 Job reasonsnone Selection computed for commit |
Description
Fixes the PR documentation recovery workflow regression proven by run 32057063327. gh-aw v0.86.2 keeps
agent_output.jsonas an{ "items": [...] }envelope, but itscreate_pull_requestitem now carries the compiler-supported target override inbase; older canonical outputs carry the normalized target inbase_branch. The apply-time resolver and the shared validator used later bynotify_source_prandvalidate-docs-outcomemust support both shapes without weakening target validation.This branch now includes live
mainatf9c0e57d27ff5c6f8381054aaaef77f7837e2f20through a normal merge commit after #19446. It preserves #19446's currentbasehandling while restoring strict compatibility with legacybase_branchin both guarded consumers. Exactly onecreate_pull_requestitem is required; every present target field must be a string matchingmainor numericrelease/X.Y[.Z]; both fields must agree when present together; and missing, invalid, wrong-type, disagreeing, or duplicate items fail without falling back tomain. The notification target and actual created PR base must also match the canonical target.The generated lock workflow was recompiled from the resolved source with gh-aw v0.86.2. The merged behavioral tests retain current-base coverage from #19446 and add legacy-only success, agreement, disagreement, missing/invalid/wrong-type fields, invalid mixed fields, duplicate create items, notification mismatch, and actual-base mismatch coverage.
Post-merge validation:
gh aw compile pr-docs-check --no-check-update(compiled 1 workflow successfully with gh-aw v0.86.2)gh aw compile pr-docs-check --no-check-update --no-emit --validate(1 workflow succeeded, 0 warnings)python -m unittest discover -s .github\workflows\pr-docs-check -p test_validate_outcome.py -v(42 passed)dotnet format tests\Infrastructure.Tests\Infrastructure.Tests.csproj --no-restore --include tests\Infrastructure.Tests\WorkflowScripts\PrDocsCheckWorkflowTests.cs --verbosity minimal(completed successfully)dotnet test --project tests\Infrastructure.Tests\Infrastructure.Tests.csproj --no-launch-profile -- --filter-class "*.PrDocsCheckWorkflowTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"(6 passed)git diff --checkandgit diff --cached --check(passed)Checklist
<remarks />and<code />elements on your triple slash comments?