Skip to content

Fix docs safe-output base resolution - #19446

Open
David Pine (IEvangelist) wants to merge 2 commits into
mainfrom
dapine/fix-docs-safe-output-base
Open

Fix docs safe-output base resolution#19446
David Pine (IEvangelist) wants to merge 2 commits into
mainfrom
dapine/fix-docs-safe-output-base

Conversation

@IEvangelist

@IEvangelist David Pine (IEvangelist) commented Aug 17, 2026

Copy link
Copy Markdown
Member

Description

Fixes the PR Documentation Check failure seen in workflow_dispatch run 32057063327. gh-aw v0.86.2 canonicalizes create_pull_request items into /tmp/gh-aw/agent_output.json with the target branch in base; the custom safe-output resolver and post-safe-output validator were still reading the stripped base_branch extension.

Both canonical-output consumers now read base while retaining the strict main or versioned release/* validation. Focused resolver, validator, fixture, and compiled-workflow assertions guard against regressing to base_branch. Only pr-docs-check.lock.yml was regenerated with gh-aw v0.86.2; the validator follow-up does not require recompilation because it is loaded as a runtime script.

Validation:

  • python -m unittest discover -s .github\workflows\pr-docs-check -p test_validate_outcome.py -v: 38 passed
  • dotnet test --project tests\Infrastructure.Tests\Infrastructure.Tests.csproj --no-launch-profile -- --filter-class "*.PrDocsCheckWorkflowTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true": 6 passed
  • gh aw compile pr-docs-check --action-mode action --action-tag v0.86.2 --no-check-update --no-emit --validate: succeeded, 1 workflow, 0 warnings
  • gh aw --version: v0.86.2

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Read the canonical create_pull_request base field produced by gh-aw v0.86.2 and keep the generated workflow and focused infrastructure assertions aligned.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19446

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19446"

@github-actions github-actions Bot added the area-engineering-systems infrastructure helix infra engineering repo stuff label Aug 17, 2026
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes canonical base resolution in the PR Documentation Check workflow.

Changes:

  • Reads canonical base instead of base_branch.
  • Adds source and compiled-workflow regression assertions.
  • Regenerates the compiled workflow.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/pr-docs-check.md Updates safe-output base resolution.
.github/workflows/pr-docs-check.lock.yml Regenerates the compiled workflow.
tests/Infrastructure.Tests/WorkflowScripts/PrDocsCheckWorkflowTests.cs Verifies canonical base usage.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/pr-docs-check.md
Use gh-aw v0.86.2's canonical create_pull_request base field in post-safe-output validation and cover both canonical and legacy payload shapes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 1d00cc1c-deac-48c4-95d9-046c2515623e
Copilot AI review requested due to automatic review settings August 17, 2026 19:45
@IEvangelist

Copy link
Copy Markdown
Member Author

Closing as a duplicate of #19445, which already contains the gh-aw v0.86.2 canonical base resolver and post-safe-output validator fixes. This PR was created from a stale cross-session handoff.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@github-actions

Copy link
Copy Markdown
Contributor

Tests selector (audit mode)

The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement.

1 / 101 test projects · 0 jobs, from 5 changed files.

Selected test projects (1 / 101)

Infrastructure.Tests

Selected jobs (0)

none


How these were chosen — grouped by what changed

📄 .github/workflows/pr-docs-check.lock.yml (changed)
1 directly: Infrastructure.Tests

📄 .github/workflows/pr-docs-check.md (changed)
1 directly: Infrastructure.Tests

📄 .github/workflows/pr-docs-check/test_validate_outcome.py (changed)
1 directly: Infrastructure.Tests

📄 .github/workflows/pr-docs-check/validate_outcome.py (changed)
1 directly: Infrastructure.Tests

🧪 tests/Infrastructure.Tests/WorkflowScripts/PrDocsCheckWorkflowTests.cs (changed test)
1 directly: Infrastructure.Tests

Job reasons

none


Selection computed for commit d56fae8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-engineering-systems infrastructure helix infra engineering repo stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants