Fix docs safe-output base resolution - #19446
Conversation
Read the canonical create_pull_request base field produced by gh-aw v0.86.2 and keep the generated workflow and focused infrastructure assertions aligned. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19446Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19446" |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Fixes canonical base resolution in the PR Documentation Check workflow.
Changes:
- Reads canonical
baseinstead ofbase_branch. - Adds source and compiled-workflow regression assertions.
- Regenerates the compiled workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/pr-docs-check.md |
Updates safe-output base resolution. |
.github/workflows/pr-docs-check.lock.yml |
Regenerates the compiled workflow. |
tests/Infrastructure.Tests/WorkflowScripts/PrDocsCheckWorkflowTests.cs |
Verifies canonical base usage. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Use gh-aw v0.86.2's canonical create_pull_request base field in post-safe-output validation and cover both canonical and legacy payload shapes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d00cc1c-deac-48c4-95d9-046c2515623e
|
Closing as a duplicate of #19445, which already contains the gh-aw v0.86.2 canonical base resolver and post-safe-output validator fixes. This PR was created from a stale cross-session handoff. |
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 1 / 101 test projects · 0 jobs, from 5 changed files. Selected test projects (1 / 101)
Selected jobs (0)none How these were chosen — grouped by what changed📄 📄 📄 📄 🧪 Job reasonsnone Selection computed for commit |
Description
Fixes the PR Documentation Check failure seen in workflow_dispatch run 32057063327. gh-aw v0.86.2 canonicalizes
create_pull_requestitems into/tmp/gh-aw/agent_output.jsonwith the target branch inbase; the custom safe-output resolver and post-safe-output validator were still reading the strippedbase_branchextension.Both canonical-output consumers now read
basewhile retaining the strictmainor versionedrelease/*validation. Focused resolver, validator, fixture, and compiled-workflow assertions guard against regressing tobase_branch. Onlypr-docs-check.lock.ymlwas regenerated with gh-aw v0.86.2; the validator follow-up does not require recompilation because it is loaded as a runtime script.Validation:
python -m unittest discover -s .github\workflows\pr-docs-check -p test_validate_outcome.py -v: 38 passeddotnet test --project tests\Infrastructure.Tests\Infrastructure.Tests.csproj --no-launch-profile -- --filter-class "*.PrDocsCheckWorkflowTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true": 6 passedgh aw compile pr-docs-check --action-mode action --action-tag v0.86.2 --no-check-update --no-emit --validate: succeeded, 1 workflow, 0 warningsgh aw --version:v0.86.2Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?