Skip to content

style(raw-reads): use the repo's 100-character line length - #7274

Draft
corneliusroemer-agent wants to merge 1 commit into
mainfrom
raw-reads-ruff-line-length
Draft

style(raw-reads): use the repo's 100-character line length#7274
corneliusroemer-agent wants to merge 1 commit into
mainfrom
raw-reads-ruff-line-length

Conversation

@corneliusroemer-agent

@corneliusroemer-agent corneliusroemer-agent commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Why

raw-reads-processing/pyproject.toml declares [tool.ruff.lint.per-file-ignores], and that alone makes it a ruff configuration root. Ruff does not merge configs across directories, so the package inherits nothing from the root ruff.toml — including its line-length = 100. It has been silently using ruff's default of 88.

That makes it the odd one out, and by accident rather than by choice:

package line length how
ena-submission, taxonomy 100 inherits root ruff.toml
ingest, preprocessing/nextclade 100 own ruff.toml, set explicitly
cli 88 own config, set explicitly — deliberate
raw-reads-processing 88 own config, never set — ruff's default

The practical cost is that running ruff format from the repo root, where the length is 100, does not reproduce what CI checks from inside the package. I hit exactly that on #7266: the check passed locally and failed in CI.

Worth noting the same inheritance gap applies to the lint rules — the package gets ruff's defaults rather than the root's extend-select list. The "test/**" = ["S101"] ignore that is already there is inert for that reason, since S is not selected. I have not changed that here; it would surface a batch of new findings and deserves its own decision.

What a reviewer should check

The reformat is mechanical (ruff format at the new width) and touches 8 files. Tests pass unchanged.

Note this overlaps #7266, which touches three of the same files. Whichever merges second will need a reformat — happy to rebase this one on top of that if you would rather land #7266 first.

🚀 Preview: Add preview label to enable

raw-reads-processing/pyproject.toml declares [tool.ruff.lint.per-file-ignores],
which makes it a ruff configuration root. It inherits nothing from the root
ruff.toml, so it silently fell back to ruff's default line-length of 88 while
ingest and preprocessing both set 100 and ena-submission inherits the root's
100. Only cli deliberately uses 88.

The practical effect is that running ruff from the repo root, where the line
length is 100, does not reproduce what CI checks from inside the package.

Set line-length explicitly and reformat.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013wgBKxVSaukBXBazE6uGTQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant