style(raw-reads): use the repo's 100-character line length - #7274
Draft
corneliusroemer-agent wants to merge 1 commit into
Draft
style(raw-reads): use the repo's 100-character line length#7274corneliusroemer-agent wants to merge 1 commit into
corneliusroemer-agent wants to merge 1 commit into
Conversation
raw-reads-processing/pyproject.toml declares [tool.ruff.lint.per-file-ignores], which makes it a ruff configuration root. It inherits nothing from the root ruff.toml, so it silently fell back to ruff's default line-length of 88 while ingest and preprocessing both set 100 and ena-submission inherits the root's 100. Only cli deliberately uses 88. The practical effect is that running ruff from the repo root, where the line length is 100, does not reproduce what CI checks from inside the package. Set line-length explicitly and reformat. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013wgBKxVSaukBXBazE6uGTQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
raw-reads-processing/pyproject.tomldeclares[tool.ruff.lint.per-file-ignores], and that alone makes it a ruff configuration root. Ruff does not merge configs across directories, so the package inherits nothing from the rootruff.toml— including itsline-length = 100. It has been silently using ruff's default of 88.That makes it the odd one out, and by accident rather than by choice:
ena-submission,taxonomyruff.tomlingest,preprocessing/nextcladeruff.toml, set explicitlycliraw-reads-processingThe practical cost is that running
ruff formatfrom the repo root, where the length is 100, does not reproduce what CI checks from inside the package. I hit exactly that on #7266: the check passed locally and failed in CI.Worth noting the same inheritance gap applies to the lint rules — the package gets ruff's defaults rather than the root's
extend-selectlist. The"test/**" = ["S101"]ignore that is already there is inert for that reason, sinceSis not selected. I have not changed that here; it would surface a batch of new findings and deserves its own decision.What a reviewer should check
The reformat is mechanical (
ruff formatat the new width) and touches 8 files. Tests pass unchanged.Note this overlaps #7266, which touches three of the same files. Whichever merges second will need a reformat — happy to rebase this one on top of that if you would rather land #7266 first.
🚀 Preview: Add
previewlabel to enable