Remove case studies - #57043
Conversation
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This PR does more than remove the case studies from https://k8s.io/ I am happy to see them go, but I should point out that https://kubernetes.io/community/ and https://kubernetes.io/case-studies/ would also be affected. |
|
Thanks, I'll go address those. |
|
See https://deploy-preview-57043--kubernetes-io-main-staging.netlify.app/community/ for a page that - at the time of writing - has a broken link. We should (or maybe just could) update that link to go to https://www.cncf.io/case-studies?_sft_lf-project=kubernetes However, soft LGTM. Making this change improves our site. |
|
/retitle Remove case studies /lgtm I'll let others handle approval. |
|
LGTM label has been added. DetailsGit tree hash: 52ebbf2c96e6e77d158b5444d7df864742e89e13 |
|
I edited the PR description to mention #48432 as extra context. |
|
I would love this to be mentioned in today's SIG Docs community meeting, since we'll also want to give our localizations a heads up that this change has taken place (not all of them have the case studies translated, but some do feature them on site in English anyhow), but to help, I'll add the approval needed so that it can be unheld once the community has met – thanks @katcosgrove 🚀 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natalisucks The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Also check if these could be removed |
|
@katcosgrove when is this change OK to unhold? Maybe defer unholding 'til after the 1.37 minor release, but tip off localization subproject(s) about the time line. How does that sound? |
|
I opened a PR against this fork to cover TineoC comments - katcosgrove#2 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Addresses the two review comments from @TineoC on kubernetes#57043 that were left unresolved: - Remove content/en/docs/contribute/new-content/case-studies.md (kubernetes#57043 (comment)), which documented how to submit a case study for a section that no longer exists, and drop the now-dangling links to it from content/en/docs/contribute/docs.md and content/en/docs/contribute/new-content/_index.md. - Remove static/css/new-case-studies.css and static/css/case-studies-gradient.css (kubernetes#57043 (comment)), which were already unused anywhere in the site before this change.
Addresses one of two review comments from @TineoC on kubernetes#57043: kubernetes#57043 (comment) Removes content/en/docs/contribute/new-content/case-studies.md, which documented how to submit a case study for a section that no longer exists, and drops the now-dangling links to it from content/en/docs/contribute/docs.md and content/en/docs/contribute/new-content/_index.md. Does not touch static/css/new-case-studies.css or static/css/case-studies-gradient.css, which TineoC also flagged (kubernetes#57043 (comment)): per katcosgrove's own review reply (kubernetes#57043 (comment)), "We can't remove the CSS. The case studies still exist in other localizations." Leaving those alone per that call.
|
Update: closed katcosgrove#3 (the localized-content removal). It ran ahead of the actual process, katcosgrove's reply above says the case studies still exist in other localizations, and @lmktfy's note about tipping off localization subprojects on timing (#57043 (comment)) hasn't happened yet even for the English-only removal. That's a call for those subprojects to make, not something to pre-empt in a follow-up PR. katcosgrove#2 (removing the orphaned |
Description
Removes the call to the case studies block and the case studies themselves, since we no longer use or update these.
cc: @kubernetes/sig-docs-leads @kubernetes/steering-committee
More context: #48432
/hold
/area web-development
/kind design